Harden command parsing

[devnoname120]

UDP is unreliable, the client and the server can crash when information is not properly transmitted. Also, there is no integrity verification on the transmitted eboot.bin for the command reload.

Either:

• Use TCP ▶️ it's already the case
• Harden the packet parsing (at least add a packet hash and drop packets that are incorrect).

[Cpasjuste]

Hi,

I'm not sure what you are talking about, it does use TCP ?!

[devnoname120]

This was a wrong assumption on my side.
Still, I often experience crashes when using the library with an unreliable network (both the Vita and PC executable).

[Cpasjuste]

Hi @devnoname120 , it seems a lot more reliable now as a plugin. It still, sometime, crash on disconnection/re-connection. I located the problem in readline here : https://github.com/Cpasjuste/psp2shell/blob/master/psp2shell_cli/source/main.c#L280 . Still not sure what the problem is but i'll try to take a closer look soon.

[devnoname120]

Thanks @Cpasjuste. :)