Adds Sleep to Cluster Annotation Test

tony-landreth · tony-landreth · commit edaaa0cfb3fd · 2022-10-13T11:18:24.000-04:00
The requireClusterReady helper in suite_helpers_test.go
does not always wait until the cluster is truly ready.
Consequently, 'on_update' in cluster_annotation_test.go
flakes, attempting to run update on a pod that isn't ready.

[sc-15828]
diff --git a/testing/pgo_cli/cluster_annotation_test.go b/testing/pgo_cli/cluster_annotation_test.go
@@ -216,6 +216,9 @@ func TestClusterAnnotation(t *testing.T) {
 						requirePgBouncerReady(t, namespace(), test.testName, (2 * time.Minute))
 					}
 
+					// Allow pods time to reach ready status before running update.
+					time.Sleep(time.Minute + 30*time.Second)
+
 					updateCMD := []string{"update", "cluster", test.testName, "-n", namespace(), "--no-prompt"}
 					updateCMD = append(updateCMD, test.addFlags...)
 					output, err = pgo(updateCMD...).Exec(t)

Original file line number	Diff line number	Diff line change
`@@ -216,6 +216,9 @@ func TestClusterAnnotation(t *testing.T) {`
`216`	`216`	`requirePgBouncerReady(t, namespace(), test.testName, (2 * time.Minute))`
`217`	`217`	`}`
`218`	`218`
	`219`	`+ // Allow pods time to reach ready status before running update.`
	`220`	`+ time.Sleep(time.Minute + 30*time.Second)`
	`221`	`+`
`219`	`222`	`updateCMD := []string{"update", "cluster", test.testName, "-n", namespace(), "--no-prompt"}`
`220`	`223`	`updateCMD = append(updateCMD, test.addFlags...)`
`221`	`224`	`output, err = pgo(updateCMD...).Exec(t)`