Add asserts to v2 endpoints (#1357)

Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com>
Co-authored-by: api-clients-generation-pipeline[bot] <54105614+api-clients-generation-pipeline[bot]@users.noreply.github.com>

Author: api-clients-generation-pipeline[bot]

.apigentools-info

@@ -4,13 +4,13 @@
     "spec_versions": {
         "v1": {
             "apigentools_version": "1.6.4",
-            "regenerated": "2023-02-28 10:12:58.070193",
-            "spec_repo_commit": "c16e3609"
+            "regenerated": "2023-03-01 15:45:43.208411",
+            "spec_repo_commit": "8905444b"
         },
         "v2": {
             "apigentools_version": "1.6.4",
-            "regenerated": "2023-02-28 10:12:58.181402",
-            "spec_repo_commit": "c16e3609"
+            "regenerated": "2023-03-01 15:45:43.222537",
+            "spec_repo_commit": "8905444b"
         }
     }
 }

examples/v2/logs-metrics/CreateLogsMetric.py

@@ -13,7 +13,7 @@
 
 body = LogsMetricCreateRequest(
     data=LogsMetricCreateData(
-        id="Example-Create_a_log_based_metric_returns_OK_response",
+        id="ExampleCreatealogbasedmetricreturnsOKresponse",
         type=LogsMetricType.LOGS_METRICS,
         attributes=LogsMetricCreateAttributes(
             compute=LogsMetricCompute(

tests/v2/cassettes/test_scenarios/test_create_a_logbased_metric_returns_ok_response.frozen

@@ -1 +1 @@
-2022-11-21T15:36:05.545Z
+2023-02-24T19:02:01.538Z

tests/v2/cassettes/test_scenarios/test_create_a_logbased_metric_returns_ok_response.yaml

@@ -1,6 +1,6 @@
 interactions:
 - request:
-    body: '{"data":{"attributes":{"compute":{"aggregation_type":"distribution","include_percentiles":true,"path":"@duration"}},"id":"Test-Create_a_log_based_metric_returns_OK_response-1669044965","type":"logs_metrics"}}'
+    body: '{"data":{"attributes":{"compute":{"aggregation_type":"distribution","include_percentiles":true,"path":"@duration"}},"id":"TestCreatealogbasedmetricreturnsOKresponse1677265321","type":"logs_metrics"}}'
     headers:
       accept:
       - application/json
@@ -10,7 +10,7 @@ interactions:
     uri: https://api.datadoghq.com/api/v2/logs/config/metrics
   response:
     body:
-      string: '{"data":{"attributes":{"filter":{"query":"*"},"group_by":[],"compute":{"path":"@duration","include_percentiles":true,"aggregation_type":"distribution"}},"type":"logs_metrics","id":"Test_Create_a_log_based_metric_returns_OK_response_1669044965"}}
+      string: '{"data":{"id":"TestCreatealogbasedmetricreturnsOKresponse1677265321","attributes":{"filter":{"query":"*"},"group_by":[],"compute":{"aggregation_type":"distribution","path":"@duration","include_percentiles":true}},"type":"logs_metrics"}}
 
         '
     headers:
@@ -25,7 +25,7 @@ interactions:
       accept:
       - '*/*'
     method: DELETE
-    uri: https://api.datadoghq.com/api/v2/logs/config/metrics/Test_Create_a_log_based_metric_returns_OK_response_1669044965
+    uri: https://api.datadoghq.com/api/v2/logs/config/metrics/TestCreatealogbasedmetricreturnsOKresponse1677265321
   response:
     body:
       string: '{}

tests/v2/cassettes/test_scenarios/test_get_all_monitor_configuration_policies_returns_ok_response.frozen

@@ -1 +1 @@
-2023-01-19T19:59:42.355Z
+2023-02-27T21:53:03.795Z

tests/v2/cassettes/test_scenarios/test_get_all_monitor_configuration_policies_returns_ok_response.yaml

@@ -1,4 +1,24 @@
 interactions:
+- request:
+    body: '{"data":{"attributes":{"policy":{"tag_key":"dc","tag_key_required":true,"valid_tag_values":["prod","staging"]},"policy_type":"tag"},"type":"monitor-config-policy"}}'
+    headers:
+      accept:
+      - application/json
+      content-type:
+      - application/json
+    method: POST
+    uri: https://api.datadoghq.com/api/v2/monitor/policy
+  response:
+    body:
+      string: '{"data":{"type":"monitor-config-policy","id":"1c8a8eea-b6e9-11ed-a4ec-da7ad0900002","attributes":{"policy_type":"tag","policy":{"tag_key":"dc","valid_tag_values":["prod","staging"],"tag_key_required":true}}}}
+
+        '
+    headers:
+      content-type:
+      - application/json
+    status:
+      code: 200
+      message: OK
 - request:
     body: null
     headers:
@@ -8,7 +28,7 @@ interactions:
     uri: https://api.datadoghq.com/api/v2/monitor/policy
   response:
     body:
-      string: '{"data":[]}
+      string: '{"data":[{"type":"monitor-config-policy","id":"1c8a8eea-b6e9-11ed-a4ec-da7ad0900002","attributes":{"policy_type":"tag","policy":{"tag_key_required":true,"valid_tag_values":["prod","staging"],"tag_key":"dc"}}}]}
 
         '
     headers:
@@ -17,4 +37,20 @@ interactions:
     status:
       code: 200
       message: OK
+- request:
+    body: null
+    headers:
+      accept:
+      - '*/*'
+    method: DELETE
+    uri: https://api.datadoghq.com/api/v2/monitor/policy/1c8a8eea-b6e9-11ed-a4ec-da7ad0900002
+  response:
+    body:
+      string: ''
+    headers:
+      content-type:
+      - text/html; charset=utf-8
+    status:
+      code: 204
+      message: No Content
 version: 1

tests/v2/features/authn_mappings.feature

@@ -30,6 +30,9 @@ Feature: AuthN Mappings
     And body with value {"data": {"attributes": {"attribute_key": "{{ unique_lower_alnum }}", "attribute_value": "{{ unique }}"}, "relationships": {"role": {"data": {"id": "{{ role.data.id }}", "type": "roles"}}}, "type": "authn_mappings"}}
     When the request is sent
     Then the response status is 200 OK
+    And the response "data.attributes.attribute_key" is equal to "{{ unique_lower_alnum }}"
+    And the response "data.attributes.attribute_value" is equal to "{{ unique }}"
+    And the response "data.relationships.role.data.id" is equal to "{{ role.data.id }}"
 
   @generated @skip @team:DataDog/team-aaa
   Scenario: Delete an AuthN Mapping returns "Not Found" response
@@ -80,6 +83,10 @@ Feature: AuthN Mappings
     And body with value {"data": {"attributes": {"attribute_key": "member-of", "attribute_value": "Development"}, "id": "{{ authn_mapping.data.id }}", "relationships": {"role": {"data": {"id": "{{ role.data.id }}", "type": "roles"}}}, "type": "authn_mappings"}}
     When the request is sent
     Then the response status is 200 OK
+    And the response "data.id" is equal to "{{ authn_mapping.data.id }}"
+    And the response "data.attributes.attribute_key" is equal to "member-of"
+    And the response "data.attributes.attribute_value" is equal to "Development"
+    And the response "data.relationships.role.data.id" is equal to "{{ role.data.id }}"
 
   @generated @skip @team:DataDog/team-aaa
   Scenario: Edit an AuthN Mapping returns "Unprocessable Entity" response
@@ -104,6 +111,10 @@ Feature: AuthN Mappings
     And request contains "authn_mapping_id" parameter from "authn_mapping.data.id"
     When the request is sent
     Then the response status is 200 OK
+    And the response "data.id" is equal to "{{ authn_mapping.data.id }}"
+    And the response "data.attributes.attribute_key" is equal to "{{ unique_lower_alnum }}"
+    And the response "data.attributes.attribute_value" is equal to "{{ unique }}"
+    And the response "data.relationships.role.data.id" is equal to "{{ role.data.id }}"
 
   @team:DataDog/team-aaa
   Scenario: List all AuthN Mappings returns "OK" response
@@ -112,3 +123,4 @@ Feature: AuthN Mappings
     And new "ListAuthNMappings" request
     When the request is sent
     Then the response status is 200 OK
+    And the response "data[0].type" is equal to "authn_mappings"

tests/v2/features/ci_visibility_pipelines.feature

@@ -20,6 +20,7 @@ Feature: CI Visibility Pipelines
     And body with value {"compute": [{"aggregation": "pc90", "metric": "@duration", "type": "total"}], "filter": {"from": "now-15m", "query": "@ci.provider.name:(gitlab OR github)", "to": "now"}, "group_by": [{ "facet": "@ci.status", "limit": 10, "total": false}], "options": {"timezone": "GMT"}}
     When the request is sent
     Then the response status is 200 OK
+    And the response "meta.status" is equal to "done"
 
   @generated @skip @team:Datadog/ci-app-backend @team:Datadog/integrations-tools-and-libraries
   Scenario: Get a list of pipelines events returns "Bad Request" response

tests/v2/features/ci_visibility_tests.feature

@@ -20,6 +20,7 @@ Feature: CI Visibility Tests
     And body with value {"compute": [{"aggregation": "count", "metric": "@test.is_flaky", "type": "total"}], "filter": {"from": "now-15m", "query": "@language:(python OR go)", "to": "now"}, "group_by": [{"facet": "@git.branch", "limit": 10, "sort": {"order": "asc"}, "total": false}], "options": {"timezone": "GMT"}}
     When the request is sent
     Then the response status is 200 OK
+    And the response "meta.status" is equal to "done"
 
   @generated @skip @team:Datadog/ci-app-backend @team:Datadog/integrations-tools-and-libraries
   Scenario: Get a list of tests events returns "Bad Request" response

tests/v2/features/cloudflare_integration.feature

@@ -35,6 +35,9 @@ Feature: Cloudflare Integration
     And body with value {"data": {"attributes": {"api_key": "6Zm7WEgKzAlCnt_4exfEK0mSoeHHAaDf41O1AAfu", "email": "new@email", "name": "{{ unique_lower_alnum }}"}, "type": "cloudflare-accounts"}}
     When the request is sent
     Then the response status is 201 CREATED
+    And the response "data.type" is equal to "cloudflare-accounts"
+    And the response "data.attributes.email" is equal to "new@email"
+    And the response "data.attributes.name" is equal to "{{ unique_lower_alnum }}"
 
   @generated @skip @team:Datadog/web-integrations
   Scenario: Add Cloudflare account returns "Not Found" response
@@ -85,6 +88,9 @@ Feature: Cloudflare Integration
     And request contains "account_id" parameter from "cloudflare_account.data.id"
     When the request is sent
     Then the response status is 200 OK
+    And the response "data.type" is equal to "cloudflare-accounts"
+    And the response "data.attributes.email" is equal to "dev@datadog.com"
+    And the response "data.attributes.name" is equal to "{{ unique_lower_alnum }}"
 
   @generated @skip @team:Datadog/web-integrations
   Scenario: List Cloudflare accounts returns "Bad Request" response
@@ -104,6 +110,7 @@ Feature: Cloudflare Integration
     And new "ListCloudflareAccounts" request
     When the request is sent
     Then the response status is 200 OK
+    And the response "data[0].type" is equal to "cloudflare-accounts"
 
   @generated @skip @team:Datadog/web-integrations
   Scenario: Update Cloudflare account returns "Bad Request" response