From 5a2d2a2b2511b4b416afcd7ec1d3b75a9108d4d3 Mon Sep 17 00:00:00 2001 From: Zarir Hamza Date: Tue, 16 Jun 2026 15:10:13 -0400 Subject: [PATCH] ci: drop redundant NodeGYP install step The unit-test matrix had a step that ran `yarn global add node-gyp` for Node 20.19, 22.11, and 24.11. This started failing on every PR and on main once node-gyp@13 released, because node-gyp@13 pulls proc-log@7.0.0, which declares engines as ^22.22.2 || ^24.15.0 || >=26.0.0 -- rejecting every Node version in our matrix. Rather than pin around the upstream churn, drop the step. node-gyp is only needed as a fallback to compile native addons at install time, and the modern npm bundled with Node 20+ already ships its own node-gyp for that purpose. The 18.12 matrix entry has never run this step and installs cleanly, which is evidence the global install was already redundant. If a future native dependency genuinely needs node-gyp on a specific Node version, we can reintroduce it with an explicit pin scoped to that need. --- .github/workflows/build.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 935eeafe..3dce9512 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -66,10 +66,6 @@ jobs: key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} restore-keys: | ${{ runner.os }}-yarn- - - name: Install NodeGYP - if: matrix.node-version == '20.19' || matrix.node-version == '22.11' || matrix.node-version == '24.11' - run: yarn global add node-gyp - - name: Install dependencies run: yarn install