From 1713f9ca76d96fa628b03c1e8c29834b7378d03b Mon Sep 17 00:00:00 2001 From: Augusto de Oliveira Date: Mon, 7 Sep 2026 16:21:48 +0200 Subject: [PATCH] ci: gate notify-slo-breaches like check-slo-breaches The fallthrough rule for notify-slo-breaches carried no `when:`, so the job inherited `when: always` from the template and ran in pipelines where check-slo-breaches itself fell through to `when: manual` and was never triggered. Since the notifier tests for the check-completed marker file rather than an exit code, a check that never ran looks the same as one that failed, and scheduled master pipelines without NIGHTLY_BENCHMARKS alerted "SLO checks failed to complete" with nothing wrong. Co-Authored-By: Claude Opus 5 --- .gitlab/benchmarks.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.gitlab/benchmarks.yml b/.gitlab/benchmarks.yml index 14f1a1bd02..d48b8a2f42 100644 --- a/.gitlab/benchmarks.yml +++ b/.gitlab/benchmarks.yml @@ -131,7 +131,9 @@ workflow: - if: '($CI_COMMIT_REF_NAME == "master" && ($NIGHTLY_BENCHMARKS || $CI_PIPELINE_SOURCE != "schedule")) || $CI_COMMIT_REF_NAME =~ /^ddtrace-/' when: always interruptible: false - - interruptible: true + - when: manual + allow_failure: true + interruptible: true .microbenchmarks: stage: benchmarks