fix: improved thing tests wrt creating a new thing

Author: jirhiker

api/thing.py

@@ -221,8 +221,6 @@ def create_thing(
     """
     Create a new well in the database.
     """
-    # print("Creating well with data:", well_data, user)
-
     return add_thing(session, thing_data)
 
 

db/location.py

@@ -36,6 +36,7 @@ class Location(Base, AutoBaseMixin, ReleaseMixin):
     # visible = Column(Boolean, default=False, nullable=False)
     __versioned__ = {}
 
+    name = mapped_column(String(255), nullable=True)
     notes = mapped_column(Text, nullable=True)
     point: Mapped[WKBElement] = mapped_column(
         Geometry(geometry_type="POINT", srid=4326, spatial_index=True)

schemas_v2/thing.py

@@ -34,18 +34,14 @@ class CreateThingIdLink(BaseModel):
     alternate_organization: str
 
 
-class CreateThing(BaseModel):
-    """
-    Schema for creating a thing.
-    """
-
+class CreateBaseThing(BaseModel):
     location_id: int | None = None  # Optional location ID for the thing
     name: str  # Name of the thing
     group: str | None = None  # Optional group ID for the thing
     thing_type: str | None = None  # Type of the thing (e.g., "Well", "Spring", etc.)
 
 
-class CreateWell(CreateThing):
+class CreateWell(CreateBaseThing):
     """
     Schema for creating a well.
     """
@@ -58,6 +54,17 @@ class CreateWell(CreateThing):
     well_construction_notes: str | None = None
 
 
+class CreateThing(CreateWell):
+    """
+    Schema for creating a thing.
+    """
+
+
+
+
+
+
+
 class CreateWellScreen(BaseModel):
     """
     Schema for creating a well screen.

tests/test_thing.py

@@ -72,6 +72,8 @@ def test_add_well():
     assert response.status_code == 201
     data = response.json()
     assert "id" in data
+    assert data["name"] == "Test Well"
+    assert data['well_type'] == "Monitoring"
 
     response = client.post(
         "/thing",