Skip to content

Commit 3cb782d

Browse files
committed
Merge branch 'jab-api-coverage-asset' into jab-api-coverage-group
2 parents 340d7a3 + 611ca3d commit 3cb782d

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

api/asset.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,18 @@ async def add_asset(
133133

134134

135135
# GET ==========================================================================
136+
137+
"""
138+
Developer's notes
139+
140+
Do not generate signed urls when listing ALL assets. There is a reason to
141+
generate signed urls when listing assets for a given `thing_id` because this
142+
is used by the front end to display a gallery of images all at once. This is
143+
the only case in which signed urls should be generated for a list of assets. A
144+
signed url is always generated when retrieving assets individually
145+
"""
146+
147+
136148
@router.get("")
137149
async def list_assets(
138150
session: session_dependency,

0 commit comments

Comments
 (0)