fix(well-inventory): normalize "Complete" monitoring frequency to "Not currently monitored"

- Treat source monitoring_frequency value Complete as no monitoring frequency
- Map Complete rows to monitoring_status = Not currently monitored
- Add schema and import regression coverage for the normalization
- Add unit and BDD coverage for the normalization behavior

Author: ksmuczynski

schemas/well_inventory.py

@@ -342,6 +342,25 @@ class WellInventoryRow(BaseModel):
     data_quality: DataQualityField = None
     water_level_notes: Optional[str] = None
 
+    @model_validator(mode="before")
+    @classmethod
+    def normalize_complete_monitoring_frequency(cls, data):
+        """Normalize `Complete` monitoring_frequency by clearing monitoring_frequency and setting monitoring_status to `Not currently monitored`."""
+        if not isinstance(data, dict):
+            return data
+
+        monitoring_frequency = data.get("monitoring_frequency")
+        if (
+            isinstance(monitoring_frequency, str)
+            and monitoring_frequency.strip().lower() == "complete"
+        ):
+            normalized = dict(data)
+            normalized["monitoring_frequency"] = None
+            normalized["monitoring_status"] = "Not currently monitored"
+            return normalized
+
+        return data
+
     @field_validator("date_time", mode="before")
     def make_date_time_tz_aware(cls, v):
         if isinstance(v, str):

tests/features/steps/well-inventory-csv-given.py

@@ -465,6 +465,14 @@ def step_given_row_contains_invalid_monitoring_status_value(context: Context):
     _set_content_from_df(context, df)
 
 
+@given('my CSV file contains a row with monitoring_frequency set to "Complete"')
+def step_given_row_contains_complete_monitoring_frequency(context: Context):
+    df = _get_valid_df(context)
+    df.loc[0, "monitoring_frequency"] = "Complete"
+    context.complete_monitoring_frequency_well_id = df.loc[0, "well_name_point_id"]
+    _set_content_from_df(context, df)
+
+
 @given(
     'my CSV file contains a row with a well_pump_type value that is not one of: "Submersible", "Jet", "Line Shaft", "Hand"'
 )

tests/features/steps/well-inventory-csv.py

@@ -6,6 +6,7 @@
 from behave import given, when, then
 from behave.runner import Context
 from cli.service_adapter import well_inventory_csv
+from db import Thing
 from db.engine import session_ctx
 from db.lexicon import LexiconCategory
 from services.util import convert_dt_tz_naive_to_tz_aware
@@ -415,3 +416,20 @@ def step_then_all_wells_are_imported_with_system_generated_unique_well_name(
     assert len(well_ids) == len(
         set(well_ids)
     ), "Expected unique well_name_point_id values"
+
+
+@then(
+    'the imported well with monitoring_frequency "Complete" is marked not currently monitored'
+)
+def step_then_complete_monitoring_frequency_maps_to_not_currently_monitored(
+    context: Context,
+):
+    with session_ctx() as session:
+        thing = session.scalars(
+            select(Thing).where(
+                Thing.name == context.complete_monitoring_frequency_well_id
+            )
+        ).one()
+
+        assert thing.monitoring_status == "Not currently monitored"
+        assert thing.monitoring_frequencies == []

tests/features/well-inventory-csv.feature

@@ -182,6 +182,14 @@ Feature: Bulk upload well inventory from CSV via CLI
     Then the command exits with code 0
     And all wells are imported
 
+  @positive @validation @BDMS-TBD
+  Scenario: Upload treats Complete monitoring_frequency as not currently monitored
+    Given my CSV file contains a row with monitoring_frequency set to "Complete"
+    When I run the well inventory bulk upload command
+    Then the command exits with code 0
+    And all wells are imported
+    And the imported well with monitoring_frequency "Complete" is marked not currently monitored
+
   @positive @validation @autogenerate_ids @BDMS-TBD
   Scenario: Upload succeeds and system auto-generates well_name_point_id for uppercase prefix placeholders and blanks
     Given my CSV file contains all valid columns but uses uppercase "-xxxx" placeholders and blank values for well_name_point_id

tests/test_well_inventory.py

@@ -760,6 +760,28 @@ def test_failed_project_rows_do_not_create_empty_group(tmp_path):
         assert group is None
 
 
+def test_complete_monitoring_frequency_sets_not_currently_monitored_without_frequency(
+    tmp_path,
+):
+    row = _minimal_valid_well_inventory_row()
+    row["monitoring_frequency"] = "Complete"
+
+    file_path = tmp_path / "well-inventory-complete-monitoring-frequency.csv"
+    with file_path.open("w", encoding="utf-8", newline="") as f:
+        writer = csv.DictWriter(f, fieldnames=list(row.keys()))
+        writer.writeheader()
+        writer.writerow(row)
+
+    result = well_inventory_csv(file_path)
+    assert result.exit_code == 0, result.stderr
+
+    with session_ctx() as session:
+        thing = session.query(Thing).one()
+
+        assert thing.monitoring_status == "Not currently monitored"
+        assert thing.monitoring_frequencies == []
+
+
 # =============================================================================
 # Error Handling Tests - Cover API error paths
 # =============================================================================
@@ -1388,6 +1410,15 @@ def test_blank_well_status_is_treated_as_none(self):
 
         assert model.well_status is None
 
+    def test_complete_monitoring_frequency_is_normalized(self):
+        row = _minimal_valid_well_inventory_row()
+        row["monitoring_frequency"] = "Complete"
+
+        model = WellInventoryRow(**row)
+
+        assert model.monitoring_frequency is None
+        assert model.monitoring_status.value == "Not currently monitored"
+
     def test_whitespace_only_well_status_is_treated_as_none(self):
         row = _minimal_valid_well_inventory_row()
         row["well_hole_status"] = "   "