Renames

Author: alex-kulakov

Orm/Xtensive.Orm.Tests/Model/IndexNullsDistinctTest.cs

@@ -939,11 +939,11 @@ private void BuildFiltersForPartialIndexes()
 
     private void ApplyNullsTreatment(IndexInfo index, IndexDef indexDef)
     {
-      index.IsNullDistinct =
+      index.AreNullsDistinct =
         ((index.Attributes & (IndexAttributes.Virtual | IndexAttributes.Primary)) != 0
-          || !indexDef.IsNullDistinct.HasValue)
+          || !indexDef.AreNullsDistinct.HasValue)
         ? null
-        : indexDef.IsNullDistinct;
+        : indexDef.AreNullsDistinct;
     }
 
     #endregion

Orm/Xtensive.Orm/Orm/Building/Builders/IndexBuilder.cs

@@ -143,7 +143,7 @@ private void RemoveTemporaryDefinitions()
 
     private void CorrectIndexNullTreatment()
     {
-      // If indexDef.IsNullDistinct becomes public per-index setting,
+      // If indexDef.ArNullsDistinct becomes public per-index setting,
       // this should be implemented as model inspector step with proper fixup actions
       // and BuildLog entries for every correction.
 
@@ -157,12 +157,12 @@ private void CorrectIndexNullTreatment()
           if (idx.IsSecondary && idx.IsUnique && settingSupported)
             continue;
           else 
-            idx.IsNullDistinct = null;
+            idx.AreNullsDistinct = null;
         }
       }
       else {
         foreach (var idx in affectedIndexes) {
-          idx.IsNullDistinct = null;
+          idx.AreNullsDistinct = null;
         }
       }
 
@@ -174,7 +174,7 @@ static IEnumerable<IndexDef> IndexSelector(TypeDef t)
 
       static bool NotNullFilter(IndexDef i)
       {
-        return i.IsNullDistinct.HasValue;
+        return i.AreNullsDistinct.HasValue;
       }
     }
 

Orm/Xtensive.Orm/Orm/Building/Builders/ModelBuilder.cs

@@ -376,7 +376,7 @@ private bool IsFieldAvailable(PropertyInfo property) =>
     private void ApplyNullTreatment(IndexDef index)
     {
       if (index.IsSecondary && index.IsUnique && context.SupportsNullTreatmentOption) {
-        index.IsNullDistinct = context.Configuration.UniqueNullTreatment switch {
+        index.AreNullsDistinct = context.Configuration.UniqueNullTreatment switch {
           UniqueNullTreatment.Distinct => true,
           UniqueNullTreatment.NotDistinct => false,
           _ => null

Orm/Xtensive.Orm/Orm/Building/Builders/ModelDefBuilder.cs

@@ -154,7 +154,7 @@ public LambdaExpression FilterExpression
 
     internal bool IsInherited { get; set; }
 
-    internal bool? IsNullDistinct { get; set; }
+    internal bool? AreNullsDistinct { get; set; }
 
     /// <summary>
     /// Performs additional custom processes before setting new name to this instance.

Orm/Xtensive.Orm/Orm/Building/Definitions/IndexDef.cs

@@ -279,7 +279,7 @@ public bool IsClustered
       get => (attributes & IndexAttributes.Clustered) > 0;
     }
 
-    internal bool? IsNullDistinct { get; set; }
+    internal bool? AreNullsDistinct { get; set; }
 
     /// <inheritdoc/>
     public override void UpdateState()
@@ -394,7 +394,7 @@ public IndexInfo(TypeInfo reflectedType, IndexAttributes indexAttributes, IndexI
       DeclaringIndex = ancestorIndex.DeclaringIndex;
       shortName = ancestorIndex.ShortName;
       if (!IsVirtual && IsSecondary)
-        IsNullDistinct = ancestorIndex.IsNullDistinct;
+        AreNullsDistinct = ancestorIndex.AreNullsDistinct;
 
       if (addAncestorToUnderlyings) {
         UnderlyingIndexes.Add(ancestorIndex);

Orm/Xtensive.Orm/Orm/Model/IndexInfo.cs

@@ -158,7 +158,7 @@ private void CreateSecondaryIndex(Table table, SecondaryIndexInfo indexInfo)
       var index = table.CreateIndex(indexInfo.Name);
       index.IsUnique = indexInfo.IsUnique;
       index.IsClustered = indexInfo.IsClustered;
-      index.NullTreatment = indexInfo.NullDistinct switch {
+      index.NullTreatment = indexInfo.AreNullsDistinct switch {
         null => Sql.Model.UniqueNullTreatment.Unspecified,
         true => Sql.Model.UniqueNullTreatment.Distinct,
         false => Sql.Model.UniqueNullTreatment.NotDistinct

Orm/Xtensive.Orm/Orm/Upgrade/Internals/DomainExtractedModelBuilder.cs

@@ -154,21 +154,21 @@ private void VisitIndexInfo(IndexInfo primaryIndex, IndexInfo index)
       secondaryIndex.IsUnique = index.IsUnique;
       var isClustered = index.IsClustered && providerInfo.Supports(ProviderFeatures.ClusteredIndexes);
       secondaryIndex.IsClustered = isClustered;
-      secondaryIndex.NullDistinct = index.IsNullDistinct;
+      secondaryIndex.AreNullsDistinct = index.AreNullsDistinct;
 
       if (index.IsUnique && providerInfo.Supports(ProviderFeatures.UniqueNullTreatment)) {
-        // If storage supports SQL 2023 unique nulls treatment, but no value set for NullDistinct
+        // If storage supports SQL 2023 unique nulls treatment, but no value set for AreNullsDistinct
         // it means default settings are used in domain configuration, and we should try to resolve it
         // into default treatment for storage via driver to not have changes on models comparison.
         // We expect that default behaviour will be defined as either distinct or not distinct.
-        if (!secondaryIndex.NullDistinct.HasValue)
-          secondaryIndex.NullDistinct = driver.ServerInfo.Index.NullDistinctByDefault;
+        if (!secondaryIndex.AreNullsDistinct.HasValue)
+          secondaryIndex.AreNullsDistinct = driver.ServerInfo.Index.NullDistinctByDefault;
       }
-      else if (secondaryIndex.NullDistinct.HasValue) {
+      else if (secondaryIndex.AreNullsDistinct.HasValue) {
         // Should never happen, if so then something is wrong with model building.
         // If null treatment option ever becomes public per-index setting
         // then an exception should be thrown here, but now we late-fix value to correct one.
-        secondaryIndex.NullDistinct = null;
+        secondaryIndex.AreNullsDistinct = null;
       }
 
       foreach (KeyValuePair<ColumnInfo, Direction> pair in index.KeyColumns) {

Orm/Xtensive.Orm/Orm/Upgrade/Internals/DomainModelConverter.cs

@@ -1073,7 +1073,7 @@ private Index CreateSecondaryIndex(Table table, SecondaryIndexInfo indexInfo)
       var index = table.CreateIndex(indexInfo.Name);
       index.IsUnique = indexInfo.IsUnique;
       index.IsClustered = indexInfo.IsClustered;
-      index.NullTreatment = indexInfo.NullDistinct switch {
+      index.NullTreatment = indexInfo.AreNullsDistinct switch {
         null => Sql.Model.UniqueNullTreatment.Unspecified,
         true => Sql.Model.UniqueNullTreatment.Distinct,
         false => Sql.Model.UniqueNullTreatment.NotDistinct

Orm/Xtensive.Orm/Orm/Upgrade/Internals/SqlActionTranslator.cs

@@ -189,14 +189,13 @@ protected override SecondaryIndexInfo VisitIndex(Index index)
       if (index.IsUnique && nullTreatmentSupported) {
         // if option is supported then there is no such thing as unspecified treatment,
         // index has to have either 'distinct' or 'not distinct' null treatment
-        secondaryIndexInfo.NullDistinct = index.NullTreatment == Sql.Model.UniqueNullTreatment.Distinct;
+        secondaryIndexInfo.AreNullsDistinct = index.NullTreatment == Sql.Model.UniqueNullTreatment.Distinct;
       }
       else {
         // for non unique indexes or if no support - index should have null
-        secondaryIndexInfo.NullDistinct = null;
+        secondaryIndexInfo.AreNullsDistinct = null;
       }
 
-
       foreach (var keyColumn in index.Columns) {
         var columnInfo = tableInfo.Columns[keyColumn.Column.Name];
         _ = new KeyColumnRef(secondaryIndexInfo,