Release Dewey 3.0.13 for lsmcok1#59
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| access_url = str(payload.get("presigned_access_url") or "").strip() | ||
| if not access_url: | ||
| raise HTTPException(status_code=502, detail="Share reference did not produce an access URL") | ||
| return RedirectResponse(url=access_url, status_code=status.HTTP_303_SEE_OTHER) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37944ec47b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| bucket=str(artifact_payload.get("bucket") or ""), | ||
| key=str(artifact_payload.get("key") or ""), | ||
| version_id=str(artifact_payload.get("version_id") or "").strip() or None, | ||
| expires_in=900, |
There was a problem hiding this comment.
This generates a 15-minute S3 URL unconditionally, even when the share reference is about to expire. If a share is opened seconds before expires_at, the returned URL remains usable after Dewey has marked the share expired, which breaks the share TTL contract and extends access beyond the configured window. Compute expires_in from the remaining lifetime (e.g., min(900, remaining_seconds)) so access cannot outlive expires_at.
Useful? React with 👍 / 👎.
2 participants
AWS lsmcok1 release train for 3.0.13. Focused tests and python -m build passed on AWS. Evidence log: /home/ubuntu/.local/state/dayhoff/lsmcok1/release-logs/20260520T075254Z_stage_remaining_service_prs.log