From 55dc77dd7c4650bc9003e8aa41b88f4e3d5c8dbe Mon Sep 17 00:00:00 2001 From: "dilux-bot[bot]" Date: Mon, 28 Sep 2026 19:18:12 +0000 Subject: [PATCH] docs(review): weekly review lessons 2026-09-28 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - `review-profiles/general.md` gets a new lesson: when a PR moves to a new version of a pinned workflow, check that the pin itself moved (the `uses:` SHA and the `central-ref` defaults), not only the docs. - `review-profiles/general.md` gets a new lesson: with paginated or capped APIs, aggregate over all pages (`jq -s`), and make a partial result fail the step. 🤖 AI-generated · claude-opus-5-5 (Anthropic) --- review-profiles/general.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/review-profiles/general.md b/review-profiles/general.md index 88a3157..96904f2 100644 --- a/review-profiles/general.md +++ b/review-profiles/general.md @@ -122,3 +122,5 @@ in the last 7 days; a human merges them. claim is correct: say what would settle it, and expect the caller-visible contract (trigger, inputs) in the workflow's header comment in the same pull request. +- When a pull request says it moves to a new version of a pinned workflow, check that the pin itself moved (the `uses:` SHA and every `central-ref`-style default), not only the comments and docs. Docs that describe a safeguard of the new version are wrong while the pin still points at the old one. +- With a paginated or capped API (`gh api --paginate`, a files list), check that aggregates run over all pages (`jq -s`, not per page) and that a partial result fails the step instead of passing as complete.