Skip to content

🟢 Low: ESLint react-hooks/exhaustive-deps disabled in 5 locations #52

@EVWorth

Description

@EVWorth

Problem

All use // eslint-disable-line react-hooks/exhaustive-deps to suppress missing dependency warnings in useEffect hooks. This can cause stale closures and UI bugs.

Impact

Stale state references, especially for connection-related logic where the active connection changes frequently.

Affected Files

  • src/components/editor/SQLEditor.tsx
  • src/components/editor/FormatterSettingsDialog.tsx
  • src/components/import/ImportDialog.tsx
  • src/components/layout/ConnectionTabs.tsx
  • src/components/ai/AIChatPanel.tsx

Suggested Fix

Add the missing dependencies or use useCallback/useRef to stabilize the referenced values. Audit each case to determine if it is a genuine stabilization pattern or a bug.

Severity: Low - React best practices

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingjavascriptnpm/JavaScript updates

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions