From 6a03fce7663683fb387c786c1fcc2dbd4d84a731 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Sat, 11 Jul 2026 13:20:47 +0000 Subject: [PATCH] feat(ux): Add game instructions and screen reader support for live score - Added visible keyboard instructions "Controls: Space / Up Arrow" - Separated the static text "Score:" from the dynamically updating score value. - Wrapped dynamic score inside a span with aria-live="polite" and aria-atomic="true" so screen readers don't unnecessarily repeat "Score". - Logged learning about aria-live into .Jules/palette.md Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com> --- .Jules/palette.md | 4 ++++ src/views/mario-game.njk | 16 +++++++++++++--- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/.Jules/palette.md b/.Jules/palette.md index 8ee612f..70943bb 100644 --- a/.Jules/palette.md +++ b/.Jules/palette.md @@ -12,3 +12,7 @@ ## 2025-03-23 - Game Key Scrolling **Learning:** Browsers natively scroll the page when users press Space or Arrow keys. When building a web-based game, this creates a frustrating UX where the game viewport jumps around while playing. **Action:** Always call `e.preventDefault()` on keydown events for typical game controls ("Space", "ArrowUp", etc.) when the focus is on a game container or the body. + +## 2026-07-11 - Screen Reader Support for Live Scores +**Learning:** Do not place static text (like instructions or labels) inside an `aria-live` region, as it forces screen readers to unnecessarily repeat the static text every time the dynamic content updates. Extract static text into a separate sibling element. +**Action:** Separate static labels from dynamic values and apply `aria-live` only to the element containing the changing value. diff --git a/src/views/mario-game.njk b/src/views/mario-game.njk index 67b6bd7..7fe8c9f 100644 --- a/src/views/mario-game.njk +++ b/src/views/mario-game.njk @@ -44,7 +44,7 @@ background: #2ecc71; } - #score { + #score-container { position: absolute; top: 10px; left: 10px; @@ -52,13 +52,23 @@ font-size: 20px; font-family: Arial; } + + #instructions { + position: absolute; + top: 10px; + right: 10px; + color: white; + font-size: 16px; + font-family: Arial; + }
-
Score: 0
+
Score: 0
+
Controls: Space / Up Arrow
@@ -118,7 +128,7 @@ clearInterval(move); goomba.remove(); score++; - scoreText.innerText = "Score: " + score; + scoreText.innerText = score; } else { position -= 6; goomba.style.left = position + "px";