From c17a9ac3c548a6497dc0f7d51bb3ab60405a8d39 Mon Sep 17 00:00:00 2001
From: Sebastion <sebastion@sebastion.dev>
Date: Tue, 28 Apr 2026 01:20:31 +0100
Subject: [PATCH] fix: require MinIO credentials from environment

---
 methods/EverCore/docker-compose.yaml | 4 ++--
 methods/EverCore/env.template        | 5 +++++
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/methods/EverCore/docker-compose.yaml b/methods/EverCore/docker-compose.yaml
index 29407030..74d0f6a2 100644
--- a/methods/EverCore/docker-compose.yaml
+++ b/methods/EverCore/docker-compose.yaml
@@ -78,8 +78,8 @@ services:
     container_name: memsys-milvus-minio
     restart: unless-stopped
     environment:
-      MINIO_ACCESS_KEY: minioadmin
-      MINIO_SECRET_KEY: minioadmin
+      MINIO_ACCESS_KEY: ${MINIO_ACCESS_KEY:?Set MINIO_ACCESS_KEY in your .env file}
+      MINIO_SECRET_KEY: ${MINIO_SECRET_KEY:?Set MINIO_SECRET_KEY in your .env file}
     ports:
       - "9001:9001"
       - "9000:9000"
diff --git a/methods/EverCore/env.template b/methods/EverCore/env.template
index c9495b77..c92fde20 100755
--- a/methods/EverCore/env.template
+++ b/methods/EverCore/env.template
@@ -185,6 +185,11 @@ ES_VERIFY_CERTS=false
 MILVUS_HOST=localhost
 MILVUS_PORT=19530
 
+# MinIO credentials used by Milvus object storage.
+# Change these before running docker compose; docker-compose.yaml requires them.
+MINIO_ACCESS_KEY=change-me-minio-access-key
+MINIO_SECRET_KEY=change-me-minio-secret-key
+
 
 # ===================
 # API Server Configuration