From 5765c1711ec756c9f17ddddf2372c9844e7c870a Mon Sep 17 00:00:00 2001 From: Francisco Meneses Date: Thu, 11 Jun 2026 16:47:22 -0400 Subject: [PATCH] ci: add bodyclose and errorlint to golangci-lint Extend lint coverage for HTTP body leaks and error wrapping. Fix admin client retry errors to use %w for lastErr. Co-authored-by: Cursor --- .golangci.yml | 8 ++++++++ internal/admin/client.go | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index c172efe..eda6300 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -4,13 +4,21 @@ run: linters: enable: + - bodyclose - errcheck + - errorlint - gosimple - govet - ineffassign - staticcheck - unused +linters-settings: + errorlint: + errorf: true + asserts: true + comparison: true + issues: exclude-dirs: - internal/visualize/testdata diff --git a/internal/admin/client.go b/internal/admin/client.go index ca05d36..1d86f2a 100644 --- a/internal/admin/client.go +++ b/internal/admin/client.go @@ -206,7 +206,7 @@ func (c *HTTPClient) doWrite(ctx context.Context, method, path string, payload [ } if lastErr != nil { - return nil, fmt.Errorf("%w: %v", ErrUnrecoverable, lastErr) + return nil, fmt.Errorf("%w: %w", ErrUnrecoverable, lastErr) } return nil, ErrUnrecoverable } @@ -286,7 +286,7 @@ func (c *HTTPClient) doRequest(ctx context.Context, path string, page, perPage i } if lastErr != nil { - return nil, fmt.Errorf("%w: %v", ErrUnrecoverable, lastErr) + return nil, fmt.Errorf("%w: %w", ErrUnrecoverable, lastErr) } return nil, ErrUnrecoverable }