[$250] Concierge - Incorrect LHN position when operating with tasks

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.44-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

1. Account with several chats in LHN

2. At teast 1 chat with another user (Start a chat > send message)

3. Concierge chat with all completed tasks.

4. Open Concierge chat

5. Mark any task as incomplete

6. Open any task

7. Return to Concierge chat

8. Mark incomplete task as complete

Expected Result:

Concierge position in LHN moved to the top after task is marked incomplete or to the bottom, after all tasks complete

Actual Result:

Concierge position changes after entering any task and back to main chat

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6995079_1762360737516.Screen_Recording_2025-11-05_at_18.26.54.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021987960105484903563
• Upwork Job ID: 1987960105484903563
• Last Price Increase: 2025-12-22
• Automatic offers:
• tsa321 | Contributor | 109904857

Issue Owner

Current Issue Owner: @dangrous

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[paulnjs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Concierge report changes its position unexpectedly after a user enters a task and returns to the main chat.

What is the root cause of that problem?

The issue stems from outdated reportAttributes data in the following hook:

App/src/hooks/useSidebarOrderedReports.tsx

Line 193 in 127f8cc

() => SidebarUtils.sortReportsToDisplayInLHN(deepComparedReportsToDisplayInLHN ?? {}, priorityMode, localeCompare, deepComparedReportsDrafts, reportNameValuePairs, reportAttributes),

Currently, reportAttributes is not included in the dependency array of the useCallback, which can cause stale data to be used. For example, when a user marks a task as incomplete, the Concierge report's hasOutstandingChildTask becomes true. This should cause the report to move to the top of the list. However, because reportAttributes is outdated, the requiresAttention value remains false:

App/src/libs/SidebarUtils.ts

Line 376 in 127f8cc

const requiresAttention = !!reportAttributes?.[reportID]?.requiresAttention;

As a result, the Concierge report does not move as expected. The same root cause applies when marking a task as complete—the sidebar position remains incorrect due to stale state.

What changes do you think we should make in order to solve the problem?

We should add reportAttributes to the dependency array of the useCallback:

App/src/hooks/useSidebarOrderedReports.tsx

Line 196 in 127f8cc

[deepComparedReportsToDisplayInLHN, localeCompare, deepComparedReportsDrafts],

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021987960105484903563

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[abdulrahuman5196]

@TMisiukiewicz Could you kindly check on this proposal - #74363 (comment)

The reportAttributes in the dependency list was removed here https://github.com/Expensify/App/pull/63980/files#diff-5b1129fc63fd161a78aad957a9c8e69382e403003f95e5486ff0132bbffca65f causing this issue.

Would it be fine to re-add it to solve this issue?