Skip to content

PR: Sub Issue 7 - OSS options + mark legacy classes obsolete #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JusterZhu merged 1 commit into from
May 24, 2026
+7 −2
Merged

PR: Sub Issue 7 - OSS options + mark legacy classes obsolete #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/c#/GeneralUpdate.Core/Bootstrap/GeneralClientOSS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

namespace GeneralUpdate.Core;

public sealed class GeneralClientOSS
[Obsolete("Use GeneralUpdateBootstrap with AppType=AppType.OSS instead.")] public sealed class GeneralClientOSS
{
private GeneralClientOSS() { }

Expand Down
1 change: 1 addition & 0 deletions src/c#/GeneralUpdate.Core/Bootstrap/GeneralUpdateOSS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

namespace GeneralUpdate.Core
{
[Obsolete("Use GeneralUpdateBootstrap with AppType=AppType.OSS instead. See UpdateOptions.AppType.")]
public sealed class GeneralUpdateOSS
{
private GeneralUpdateOSS() { }
Expand Down
6 changes: 5 additions & 1 deletion src/c#/GeneralUpdate.Core/Configuration/UpdateOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ public static class UpdateOptions
public static readonly UpdateOption<string?> ProductId = UpdateOption.ValueOf<string?>("PRODUCTID");
public static readonly UpdateOption<string?> PermissionScript = UpdateOption.ValueOf<string?>("PERMISSIONSCRIPT");
public static readonly UpdateOption<string?> Scheme = UpdateOption.ValueOf<string?>("SCHEME");
public static readonly UpdateOption<string?> Token = UpdateOption.ValueOf<string?>("TOKEN");
public static readonly UpdateOption<string?> Token = UpdateOption.ValueOf<string?("TOKEN");

// ═══ OSS ═══
public static readonly UpdateOption<int?> OSSProvider = UpdateOption.ValueOf<int?>("OSSPROVIDER");
public static readonly UpdateOption<string?> OSSBucketRegion = UpdateOption.ValueOf<string?>("OSSBUCKETREGION");
}
}
Loading