-
Notifications
You must be signed in to change notification settings - Fork 17
Improve caching of Instance configs #304
Copy link
Copy link
Open
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Currently we cache instance connection info by
instanceConnectionNameand error out if the iam authn flag switches between consecutive connect calls. We should update the hash key (instanceConnectionName+iam authn) for how we cache our configs so that we can handle support for flag switches without needing to error.cloud-sql-nodejs-connector/src/connector.ts
Lines 76 to 79 in 00a6eae