Fixing linting errors

Author: jmusselwhite

README.md

@@ -121,7 +121,7 @@ The script requires the following environment variables to be defined:
 * USER_PASSWORD - the password to login to the Postgres instance
 * PG_ADMIN_CONSOLE_PASSWORD - the password to login to the pgAdmin UI
 
-Here is what it looks like to run **create.sh**:  
+Here is what it looks like to run **create.sh**:
 
 ```USER_PASSWORD=password PG_ADMIN_CONSOLE_PASSWORD=password ./create.sh INSTANCE_NAME POSTGRES_USERNAME PGADMIN_USERNAME```
 

scripts/cluster.sh

@@ -20,6 +20,7 @@
 set -o errexit
 
 ROOT=$(dirname "${BASH_SOURCE[0]}")
+# shellcheck disable=SC1090
 source "${ROOT}"/constants.sh
 
 

scripts/constants.sh

@@ -1,11 +1,28 @@
-PROJECT=$(gcloud config get-value core/project)
+#!/bin/bash -e
+
+# Copyright 2018 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 
+PROJECT=$(gcloud config get-value core/project)
+export PROJECT
 CLUSTER_ZONE=$(gcloud config get-value compute/zone)
-CLUSTER_NAME=postgres-demo-cluster
+export CLUSTER_ZONE
+export CLUSTER_NAME=postgres-demo-cluster
 
 INSTANCE_REGION=$(gcloud config get-value compute/region)
-
-SA_NAME=postgres-demo-sa
-NODE_SA_NAME=postgres-demo-node-sa
-FULL_SA_NAME=$SA_NAME@$PROJECT.iam.gserviceaccount.com
-FULL_NODE_SA_NAME=$NODE_SA_NAME@$PROJECT.iam.gserviceaccount.com
+export INSTANCE_REGION
+export SA_NAME=postgres-demo-sa
+export NODE_SA_NAME=postgres-demo-node-sa
+export FULL_SA_NAME=$SA_NAME@$PROJECT.iam.gserviceaccount.com
+export FULL_NODE_SA_NAME=$NODE_SA_NAME@$PROJECT.iam.gserviceaccount.com

scripts/delete_resources.sh

@@ -19,6 +19,7 @@
 # that includes a prompt in another script
 
 ROOT=$(dirname "${BASH_SOURCE[0]}")
+# shellcheck disable=SC1090
 source "${ROOT}"/constants.sh
 
 gcloud container clusters delete \

scripts/service_account.sh

@@ -21,6 +21,7 @@
 # for logging and monitoring as recommended by the GKE documentation
 
 ROOT=$(dirname "${BASH_SOURCE[0]}")
+# shellcheck disable=SC1090
 source "${ROOT}"/constants.sh
 
 if [ -z "$PROJECT" ]; then

validate.sh

@@ -18,6 +18,7 @@
 # make sure the Cloud SQL instance is up, as well as the GKE cluster and pod
 
 ROOT=$(dirname "${BASH_SOURCE[0]}")
+# shellcheck disable=SC1090
 source "${ROOT}"/scripts/constants.sh
 
 help() {