Conflicting tag names for firebase v2/v3 elements

[jakemac53]

Both the v2 and v3 firebase collections contain elements using the tags firebase-auth and firebase-document. This makes composing together multiple elements which use different firebase api versions impossible.

[ebidel]

Use using multiple versions of the API recommended? That sounds like a bad
plan :)

On Wed, Jun 22, 2016, 10:05 AM Jacob MacDonald notifications@github.com
wrote:

Both the v2 and v3 firebase collections contain elements using the tags
firebase-auth and firebase-document. This makes composing together
multiple elements which use different firebase api versions impossible.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#7,
or mute the thread
https://github.com/notifications/unsubscribe/AAOigO30Np45zp1HOTV_eAZHRlOyq9KUks5qOWtWgaJpZM4I8AYQ
.

[jakemac53]

This applies across the entire app, not just an individual component or package. It means that anybody upgrading from v2 has to migrate their whole app at once to v3, including all your dependencies. Elements are supposed to play nicely together and having conflicting tag names fundamentally goes against that.

In this case my guess is it doesn't matter in practice, because generally firebase is used at the top level of the app somewhere, and then the models from that are propagated down to other components. Thus, your dependencies don't typically use firebase directly so conflicts are a non-issue, or at least in small/medium sized projects.

Imo, it makes sense for these types of elements to put the major api version as part of the tag name (firebase-auth-v3 for instance).

[ebidel]

This is precisely why the elements were released under a different organization. If users chose to use FB v3, they go to another place to get those elements.

[jakemac53]

The issue I was pointing out though is that both elements are provided as part of this bundle. Maybe that is an argument against the bundle rules in general?