fix: resolve compile issues, type safety bugs, security vulnerabilities, and logic flaws

Author: Patel230

cmd/git-remote-gitant/main.go

@@ -145,10 +145,10 @@ func flushFetches(daemonURL, repoID string, wants []string, writer *bufio.Writer
 	// Build pkt-line want request
 	var pktBuf bytes.Buffer
 	for _, want := range wants {
-		fmt.Fprintf(&pktBuf, "%04xwant %s\n", len("want ")+len(want)+1, want)
+		fmt.Fprintf(&pktBuf, "%04xwant %s\n", 4+len("want ")+len(want)+1, want)
 	}
 	pktBuf.WriteString("0000") // flush packet
-	fmt.Fprintf(&pktBuf, "%04xdone\n", len("done\n")+4)
+	pktBuf.WriteString("0009done\n")
 
 	endpoint := fmt.Sprintf("%s/api/v1/repos/%s/git-upload-pack", daemonURL, url.PathEscape(repoID))
 	resp, err := http.Post(endpoint, "application/x-git-upload-pack-request", &pktBuf)

cmd/gitant/agents.go

@@ -100,7 +100,7 @@ var agentDelegateCmd = &cobra.Command{
 		}
 
 		var result map[string]interface{}
-		if err := client.Post("/api/v1/agents/"+did+"/delegate", req, &result); err != nil {
+		if err := client.Post(apiPath("/api/v1/agents", did, "delegate"), req, &result); err != nil {
 			fmt.Fprintf(os.Stderr, "Error: %v\n", err)
 			os.Exit(1)
 		}

cmd/gitant/ci.go

@@ -3,6 +3,8 @@ package main
 import (
 	"fmt"
 	"os"
+	"os/exec"
+	"strings"
 
 	"github.com/GrayCodeAI/gitant-cli/internal/cli"
 	"github.com/spf13/cobra"
@@ -179,16 +181,16 @@ func shortSHA(sha string) string {
 }
 
 func getCurrentBranch() string {
-	// Try to get current branch from git
-	out, err := os.ReadFile(".git/HEAD")
+	cmd := exec.Command("git", "rev-parse", "--abbrev-ref", "HEAD")
+	out, err := cmd.Output()
 	if err != nil {
 		return "main"
 	}
-	head := string(out)
-	if len(head) > 16 && head[:16] == "ref: refs/heads/" {
-		return head[16 : len(head)-1]
+	branch := strings.TrimSpace(string(out))
+	if branch == "" || branch == "HEAD" {
+		return "main"
 	}
-	return "main"
+	return branch
 }
 
 func init() {

cmd/gitant/gitlawb_commands.go

@@ -42,7 +42,7 @@ var certListCmd = &cobra.Command{
 		}
 
 		for _, c := range result.Certificates {
-			fmt.Printf("%s\t%s\t%s→%s\t%s\t%s\n", c.ID, c.Ref, c.OldOID[:8], c.NewOID[:8], c.Signer, c.Timestamp)
+			fmt.Printf("%s\t%s\t%s→%s\t%s\t%s\n", c.ID, c.Ref, shortSHA(c.OldOID), shortSHA(c.NewOID), c.Signer, c.Timestamp)
 		}
 		fmt.Fprintf(os.Stderr, "%d certificate(s)\n", result.Total)
 	},

internal/cli/clone.go

@@ -36,7 +36,7 @@ func Clone(daemonURL, repoID, localPath string) error {
 	// For each ref, fetch the commit and all reachable objects
 	seen := make(map[string]bool)
 	for _, ref := range repoInfo.Refs {
-		if err := fetchObjectRecursive(client, repoID, repo, ref.Hash, seen); err != nil {
+		if err := fetchObjectRecursive(client, repoID, repo, ref.Hash, seen, 0); err != nil {
 			fmt.Fprintf(Stderr(), "warning: failed to fetch %s: %v\n", ref.Hash, err)
 		}
 	}
@@ -55,7 +55,10 @@ func Clone(daemonURL, repoID, localPath string) error {
 }
 
 // fetchObjectRecursive fetches an object and all its children
-func fetchObjectRecursive(client *Client, repoID string, repo *git.Repository, hashStr string, seen map[string]bool) error {
+func fetchObjectRecursive(client *Client, repoID string, repo *git.Repository, hashStr string, seen map[string]bool, depth int) error {
+	if depth > 1000 {
+		return fmt.Errorf("recursion depth limit exceeded")
+	}
 	if seen[hashStr] {
 		return nil
 	}
@@ -105,12 +108,12 @@ func fetchObjectRecursive(client *Client, repoID string, repo *git.Repository, h
 		for _, line := range strings.Split(contentStr, "\n") {
 			if strings.HasPrefix(line, "tree ") {
 				treeHash := strings.TrimPrefix(line, "tree ")
-				if err := fetchObjectRecursive(client, repoID, repo, treeHash, seen); err != nil {
+				if err := fetchObjectRecursive(client, repoID, repo, treeHash, seen, depth+1); err != nil {
 					fmt.Fprintf(Stderr(), "warning: failed to fetch tree %s: %v\n", treeHash, err)
 				}
 			} else if strings.HasPrefix(line, "parent ") {
 				parentHash := strings.TrimPrefix(line, "parent ")
-				if err := fetchObjectRecursive(client, repoID, repo, parentHash, seen); err != nil {
+				if err := fetchObjectRecursive(client, repoID, repo, parentHash, seen, depth+1); err != nil {
 					fmt.Fprintf(Stderr(), "warning: failed to fetch parent %s: %v\n", parentHash, err)
 				}
 			}
@@ -131,7 +134,7 @@ func fetchObjectRecursive(client *Client, repoID string, repo *git.Repository, h
 				break
 			}
 			entryHash := fmt.Sprintf("%x", content[nullIdx+1:nullIdx+21])
-			if err := fetchObjectRecursive(client, repoID, repo, entryHash, seen); err != nil {
+			if err := fetchObjectRecursive(client, repoID, repo, entryHash, seen, depth+1); err != nil {
 				fmt.Fprintf(Stderr(), "warning: failed to fetch tree entry %s: %v\n", entryHash, err)
 			}
 			i = nullIdx + 21
@@ -163,7 +166,7 @@ func Pull(repoPath, daemonURL, repoID string) error {
 	// Fetch objects for new refs
 	seen := make(map[string]bool)
 	for _, ref := range repoInfo.Refs {
-		if err := fetchObjectRecursive(client, repoID, repo, ref.Hash, seen); err != nil {
+		if err := fetchObjectRecursive(client, repoID, repo, ref.Hash, seen, 0); err != nil {
 			fmt.Fprintf(Stderr(), "warning: failed to fetch %s: %v\n", ref.Hash, err)
 		}
 	}

internal/cli/push.go

@@ -161,8 +161,12 @@ func collectObjects(repo *git.Repository, hashes []plumbing.Hash) ([]GitObject,
 	var objects []GitObject
 
 	for _, hash := range hashes {
+		commit, err := repo.CommitObject(hash)
+		if err != nil {
+			return nil, fmt.Errorf("loading commit %s: %w", hash.String(), err)
+		}
 		// Walk commits
-		commitIter := object.NewCommitPreorderIter(&object.Commit{Hash: hash}, nil, nil)
+		commitIter := object.NewCommitPreorderIter(commit, nil, nil)
 		commitIter.ForEach(func(c *object.Commit) error {
 			if seen[c.Hash.String()] {
 				return nil
@@ -243,6 +247,11 @@ func encodeObject(hash plumbing.Hash, objType string, repo *git.Repository) (Git
 	}
 	defer reader.Close()
 
+	const maxObjectSize = 50 * 1024 * 1024 // 50MB
+	if obj.Size() > maxObjectSize {
+		return GitObject{}, fmt.Errorf("object size %d exceeds limit of %d bytes", obj.Size(), maxObjectSize)
+	}
+
 	buf := make([]byte, obj.Size())
 	if _, err := io.ReadFull(reader, buf); err != nil {
 		return GitObject{}, err