Merge pull request #1903 from Haehnchen/feature/1366-voter-tags

#1366 mark registered voter class as used code

Author: Haehnchen

src/main/java/fr/adrienbrault/idea/symfony2plugin/codeInsight/SymfonyImplicitUsageProvider.java

@@ -32,12 +32,18 @@ public boolean isImplicitUsage(@NotNull PsiElement element) {
         } else if (element instanceof PhpClass) {
             return isRouteClass((PhpClass) element)
                 || isCommandAndService((PhpClass) element)
-                || isSubscribedEvent((PhpClass) element);
+                || isSubscribedEvent((PhpClass) element)
+                || isVoter((PhpClass) element);
         }
 
         return false;
     }
 
+    private boolean isVoter(PhpClass phpClass) {
+        return PhpElementsUtil.isInstanceOf(phpClass, "\\Symfony\\Component\\Security\\Core\\Authorization\\Voter\\VoterInterface")
+            && ServiceUtil.isPhpClassAService(phpClass);
+    }
+
     private boolean isRouteClass(@NotNull PhpClass phpClass) {
         return phpClass.getMethods()
             .stream()

src/test/java/fr/adrienbrault/idea/symfony2plugin/tests/codeInsight/SymfonyImplicitUsageProviderTest.java

@@ -137,6 +137,16 @@ public void testCommandRegisteredNotAsServiceIsUntouched() {
         assertFalse(new SymfonyImplicitUsageProvider().isImplicitUsage(firstClassFromFile));
     }
 
+    public void testVoterRegisteredAsServiceAreMarkedUsed() {
+        PsiFile psiFile = myFixture.configureByText(PhpFileType.INSTANCE, "<?php\n" +
+            "namespace App\\Voter;\n" +
+            "class MyFoobarVoter implements \\Symfony\\Component\\Security\\Core\\Authorization\\Voter\\VoterInterface {}"
+        );
+
+        PhpClass firstClassFromFile = PhpElementsUtil.getFirstClassFromFile((PhpFile) psiFile.getContainingFile());
+        assertTrue(new SymfonyImplicitUsageProvider().isImplicitUsage(firstClassFromFile));
+    }
+
     public void testEventSubscriberGetSubscribedEventsArray() {
         PsiFile psiFile = myFixture.configureByText(PhpFileType.INSTANCE, "<?php\n" +
             "<?php\n" +

src/test/java/fr/adrienbrault/idea/symfony2plugin/tests/codeInsight/fixtures/classes.php

@@ -21,4 +21,12 @@ interface EventSubscriberInterface
     {
         public static function getSubscribedEvents();
     }
+}
+
+namespace Symfony\Component\Security\Core\Authorization\Voter
+{
+    interface VoterInterface
+    {
+        public function vote(TokenInterface $token, $subject, array $attributes);
+    }
 }

src/test/java/fr/adrienbrault/idea/symfony2plugin/tests/codeInsight/fixtures/services.yml

@@ -7,3 +7,6 @@ services:
 
   foo_command.foo_command:
     class: App\Command\FooCommand
+
+  foo_command.my_foobar_voter:
+    class: App\Voter\MyFoobarVoter