Lingering service instances

[InSyncWithFoo]

Caused by: java.lang.ClassCastException: class insyncwithfoo.ryecharm.configurations.ty.TYGlobalService cannot be cast to class insyncwithfoo.ryecharm.configurations.ty.TYGlobalService (insyncwithfoo.ryecharm.configurations.ty.TYGlobalService is in unnamed module of loader com.intellij.ide.plugins.cl.PluginClassLoader @3da42dc3; insyncwithfoo.ryecharm.configurations.ty.TYGlobalService is in unnamed module of loader com.intellij.ide.plugins.cl.PluginClassLoader @26a0ef1d)

	at insyncwithfoo.ryecharm.configurations.ty.TYGlobalService$Companion.getInstance(Services.kt:57)
	at insyncwithfoo.ryecharm.configurations.ty.TYConfigurable.<init>(Configurables.kt:23)
	at com.intellij.serviceContainer.ComponentManagerImpl.findConstructorAndInstantiateClass(ComponentManagerImpl.kt:970)
	at com.intellij.serviceContainer.ComponentManagerImpl.doInstantiateClass(ComponentManagerImpl.kt:979)

See #217.

[dagl1]

Minimal reproduction:

• Start IDE with ryecharm enabled
• Disable ryecharm in plugins -> apply -> okay
• Move to a file (optional I think, but I think its important to at least focus the window on a file for type checking)
• Open options, enable plugin, press apply, DO NOT press okay, but immediately move to tool window.
• Click ty, or any other subservice
• If that doesn't work, turn off subservice or turn on/off project, apply and then disable ryecharm and repeat. On attempting to enter the tool window of any ryecharm service (in this case ty), should lead to a problem. Interestingly when doing this ruff and uv appear not affected, but had it before with ruff (two computers, both windows OS, right after upgrading pycharm version and upgrading ruff, I would get the same issue when attempting to turn on ruff).

Uninstall pluging -> restart IDE -> install plugin
seems to fix this.

[InSyncWithFoo]

Excellent. Thank you very much. I can reproduce the problem now.

[InSyncWithFoo]

@dagl1 The errors were for several classes. I could only reproduce for one of them (ParseCache), and I think I found out the cause: A service was instantiating it during the former's own disposal, when the latter has already been disposed of.

For the rest, I made a guess and also added a few logging calls. Please try installing the build manually and let me know if it works. If it doesn't, I'll need your idea.log again.

[dagl1]

I hope I understood correctly, I downloaded and installed from: https://github.com/InSyncWithFoo/ryecharm/actions/runs/24281665253

Performed the steps as before, and received the same errors. The build version is the same as the other one, so besides the 7kb difference it is hard to ensure that I clicked the right one;p, but I am fairly confident that it is still happening. To be sure uninstalled and reinstalled from disk a second time;

It appears to be the same, to note: when I just installed + enabled it, clicked okay, then went to settings to see the tools, everything was working fine. Only when I have the plugin enabled, disable it, enable it again, move to the tool window, will this happen (and so for any normal use this remains not a real issue, I am saying this last part as I am unsure if I gave the impression that this stops me from using Ryecharm, which it doesn't).

idea.log

Let me know what else you would need!

[InSyncWithFoo]

I'm glad to hear this bug didn't impede your work. Thanks to the log file, I have been able to confirm that there are no longer any errors related to ParseCache (that is, the fix works as expected), and I have figure out how to reproduce the other errors as well. I'll look into them and reply here once I know what the cause is.