From 3bd012dae548572813eb14e3443f6bd8ca71ed6f Mon Sep 17 00:00:00 2001
From: Quentin Ruhier <quentin.ruhier@insee.fr>
Date: Fri, 27 Jun 2025 13:36:12 +0200
Subject: [PATCH 1/2] fix: set survey as VALIDATED instead of COMPLETED

---
 src/enumerations/StateDataStateEnum.ts | 1 -
 src/pages/end-survey/EndSurvey.tsx     | 2 +-
 src/service/survey-service.ts          | 4 +---
 3 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/enumerations/StateDataStateEnum.ts b/src/enumerations/StateDataStateEnum.ts
index 4cebe8eb..ed41880b 100644
--- a/src/enumerations/StateDataStateEnum.ts
+++ b/src/enumerations/StateDataStateEnum.ts
@@ -3,5 +3,4 @@ export enum StateDataStateEnum {
     VALIDATED = "VALIDATED",
     TOEXTRACT = "TO-EXTRACT",
     EXTRACTED = "EXTRACTED",
-    COMPLETED = "COMPLETED",
 }
diff --git a/src/pages/end-survey/EndSurvey.tsx b/src/pages/end-survey/EndSurvey.tsx
index 75bc8934..8ab5b49e 100644
--- a/src/pages/end-survey/EndSurvey.tsx
+++ b/src/pages/end-survey/EndSurvey.tsx
@@ -91,7 +91,7 @@ const EndSurveyPage = () => {
     const remoteSaveSurveyAndGoBackHome = useCallback(() => {
         const dataWithIsEnvoyed = setValue(idSurvey, FieldNameEnum.ISENVOYED, true);
         const stateData: StateData = {
-            state: StateDataStateEnum.COMPLETED,
+            state: StateDataStateEnum.VALIDATED,
             date: Date.now(),
             currentPage: getCurrentPage(callbackHolder.getData(), context.source),
         };
diff --git a/src/service/survey-service.ts b/src/service/survey-service.ts
index 2968b517..bb4b87f1 100644
--- a/src/service/survey-service.ts
+++ b/src/service/survey-service.ts
@@ -1075,9 +1075,7 @@ const getStateOfSurvey = (idSurvey: string): StateDataStateEnum => {
     const isValidated = surveyValidated(idSurvey);
     let state: StateDataStateEnum = StateDataStateEnum.INIT;
 
-    if (isSent) {
-        state = StateDataStateEnum.COMPLETED;
-    } else if (isValidated) {
+    if (isSent || isValidated) {
         state = StateDataStateEnum.VALIDATED;
     }
     return state;

From a39bca50d0bb51808762a2147f8c8b0b3237b7ac Mon Sep 17 00:00:00 2001
From: Quentin Ruhier <quentin.ruhier@insee.fr>
Date: Fri, 27 Jun 2025 13:49:38 +0200
Subject: [PATCH 2/2] ci: upgrade action

---
 .github/workflows/ci.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index b17463b1..81b8acab 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -53,7 +53,7 @@ jobs:
                   npm test-ci --coverage
             # Build sonar reports
             - name: Upload deploy artifact
-              uses: actions/upload-artifact@v2
+              uses: actions/upload-artifact@v4
               with:
                   name: coverage
                   path: coverage/