Clear remaining SonarCloud and Codacy findings on PR 175

- english/japanese language dicts: extract _SCRIPT_LABEL / _REMOVE_SELECTED /
  _SELECT_SCRIPT / _SCRIPT to drop S1192 duplicate-literal warnings
- accessibility/vision backend factories: type the module-level cache as
  Optional[...] instead of assigning None against a non-optional hint (S5890)
- macos_backend: rename the ApplicationServices param from AS to ax_module
  so it passes S117 snake_case
- hotkey linux_backend._sync: split into _ungrab_stale / _sync_one /
  _ungrab_masked / _grab_masked helpers to bring cognitive complexity
  from 21 back under the 15-line limit
- hotkey windows_backend: iterate the dict directly in the finally block
  instead of wrapping in list() (S7504)
- HotkeyDaemon._snapshot is now an alias of list_bindings so Sonar stops
  flagging the identical body (S4144)
- change_xml_structure: lift the nested conditional into _initial_body
  (S3358)
- package_manager regex uses concise \w (S6353); history_store uses the
  _IN_MEMORY_DB constant instead of repeating ":memory:" (S1192)
- Add nosemgrep suppressions for defusedxml imports, the run_history
  SELECT builder, and the openai SDK guardrails false positive

Author: JE-Chen

je_auto_control/gui/language_wrapper/english.py

@@ -1,3 +1,7 @@
+_SCRIPT_LABEL = "Script:"
+_REMOVE_SELECTED = "Remove selected"
+_SELECT_SCRIPT = "Select script"
+
 english_word_dict = {
     # Main
     "application_name": "AutoControlGUI",
@@ -126,9 +130,9 @@
 
     # Hotkeys Tab
     "hk_combo_label": "Combo:",
-    "hk_script_label": "Script:",
+    "hk_script_label": _SCRIPT_LABEL,
     "hk_bind": "Bind",
-    "hk_remove_selected": "Remove selected",
+    "hk_remove_selected": _REMOVE_SELECTED,
     "hk_start_daemon": "Start daemon",
     "hk_stop_daemon": "Stop daemon",
     "hk_daemon_stopped": "Daemon stopped",
@@ -137,14 +141,14 @@
     "hk_col_combo": "Combo",
     "hk_col_script": "Script",
     "hk_col_fired": "Fired",
-    "hk_dialog_select_script": "Select script",
+    "hk_dialog_select_script": _SELECT_SCRIPT,
 
     # Triggers Tab
-    "tr_script_label": "Script:",
+    "tr_script_label": _SCRIPT_LABEL,
     "tr_type_label": "Type:",
     "tr_repeat": "Repeat",
     "tr_add": "Add trigger",
-    "tr_remove_selected": "Remove selected",
+    "tr_remove_selected": _REMOVE_SELECTED,
     "tr_start_engine": "Start engine",
     "tr_stop_engine": "Stop engine",
     "tr_engine_stopped": "Engine stopped",
@@ -164,7 +168,7 @@
     "tr_col_enabled": "Enabled",
     "tr_yes": "Yes",
     "tr_no": "No",
-    "tr_dialog_select_script": "Select script",
+    "tr_dialog_select_script": _SELECT_SCRIPT,
     "tr_dialog_select_image": "Select image",
     "tr_dialog_select_file": "Select file to watch",
 
@@ -176,11 +180,11 @@
     "pl_dialog_plugin_dir": "Plugin directory",
 
     # Scheduler Tab
-    "sch_script_label": "Script:",
+    "sch_script_label": _SCRIPT_LABEL,
     "sch_interval_label": "Every (s):",
     "sch_repeat": "Repeat",
     "sch_add": "Add",
-    "sch_remove_selected": "Remove selected",
+    "sch_remove_selected": _REMOVE_SELECTED,
     "sch_start": "Start scheduler",
     "sch_stop": "Stop scheduler",
     "sch_status_running": "Scheduler running",
@@ -190,7 +194,7 @@
     "sch_col_interval": "Interval (s)",
     "sch_col_runs": "Runs",
     "sch_col_enabled": "Enabled",
-    "sch_dialog_select_script": "Select script",
+    "sch_dialog_select_script": _SELECT_SCRIPT,
 
     # Socket / REST Tab
     "ss_tcp_group": "TCP socket server",
@@ -232,7 +236,7 @@
     "re_trim_start": "Trim start:",
     "re_trim_end": "end:",
     "re_apply_trim": "Apply trim",
-    "re_remove_selected": "Remove selected",
+    "re_remove_selected": _REMOVE_SELECTED,
     "re_delay_x": "Delay x",
     "re_floor_ms": "floor ms:",
     "re_apply_delays": "Apply delays",

je_auto_control/gui/language_wrapper/japanese.py

@@ -1,3 +1,8 @@
+_SCRIPT = "スクリプト"
+_SCRIPT_LABEL = "スクリプト:"
+_REMOVE_SELECTED = "選択項目を削除"
+_SELECT_SCRIPT = "スクリプトを選択"
+
 japanese_word_dict = {
     "application_name": "AutoControlGUI",
 
@@ -122,25 +127,25 @@
 
     # Hotkeys Tab
     "hk_combo_label": "組合せ:",
-    "hk_script_label": "スクリプト:",
+    "hk_script_label": _SCRIPT_LABEL,
     "hk_bind": "バインド",
-    "hk_remove_selected": "選択項目を削除",
+    "hk_remove_selected": _REMOVE_SELECTED,
     "hk_start_daemon": "デーモン開始",
     "hk_stop_daemon": "デーモン停止",
     "hk_daemon_stopped": "デーモン停止中",
     "hk_daemon_running": "デーモン実行中",
     "hk_col_id": "ID",
     "hk_col_combo": "組合せ",
-    "hk_col_script": "スクリプト",
+    "hk_col_script": _SCRIPT,
     "hk_col_fired": "発火",
-    "hk_dialog_select_script": "スクリプトを選択",
+    "hk_dialog_select_script": _SELECT_SCRIPT,
 
     # Triggers Tab
-    "tr_script_label": "スクリプト:",
+    "tr_script_label": _SCRIPT_LABEL,
     "tr_type_label": "タイプ:",
     "tr_repeat": "繰り返し",
     "tr_add": "トリガー追加",
-    "tr_remove_selected": "選択項目を削除",
+    "tr_remove_selected": _REMOVE_SELECTED,
     "tr_start_engine": "エンジン開始",
     "tr_stop_engine": "エンジン停止",
     "tr_engine_stopped": "エンジン停止中",
@@ -160,7 +165,7 @@
     "tr_col_enabled": "有効",
     "tr_yes": "はい",
     "tr_no": "いいえ",
-    "tr_dialog_select_script": "スクリプトを選択",
+    "tr_dialog_select_script": _SELECT_SCRIPT,
     "tr_dialog_select_image": "画像を選択",
     "tr_dialog_select_file": "監視するファイルを選択",
 
@@ -172,21 +177,21 @@
     "pl_dialog_plugin_dir": "プラグインディレクトリ",
 
     # Scheduler Tab
-    "sch_script_label": "スクリプト:",
+    "sch_script_label": _SCRIPT_LABEL,
     "sch_interval_label": "毎 (秒):",
     "sch_repeat": "繰り返し",
     "sch_add": "追加",
-    "sch_remove_selected": "選択項目を削除",
+    "sch_remove_selected": _REMOVE_SELECTED,
     "sch_start": "スケジューラー開始",
     "sch_stop": "スケジューラー停止",
     "sch_status_running": "スケジューラー実行中",
     "sch_status_stopped": "スケジューラー停止中",
     "sch_col_job_id": "ジョブ ID",
-    "sch_col_script": "スクリプト",
+    "sch_col_script": _SCRIPT,
     "sch_col_interval": "間隔 (秒)",
     "sch_col_runs": "実行回数",
     "sch_col_enabled": "有効",
-    "sch_dialog_select_script": "スクリプトを選択",
+    "sch_dialog_select_script": _SELECT_SCRIPT,
 
     # Socket / REST Tab
     "ss_tcp_group": "TCP ソケットサーバー",
@@ -228,7 +233,7 @@
     "re_trim_start": "トリム開始:",
     "re_trim_end": "終了:",
     "re_apply_trim": "トリム適用",
-    "re_remove_selected": "選択項目を削除",
+    "re_remove_selected": _REMOVE_SELECTED,
     "re_delay_x": "ディレイ倍率",
     "re_floor_ms": "下限 ms:",
     "re_apply_delays": "ディレイ適用",
@@ -271,7 +276,7 @@
     "rh_col_id": "ID",
     "rh_col_source": "ソース",
     "rh_col_target": "対象",
-    "rh_col_script": "スクリプト",
+    "rh_col_script": _SCRIPT,
     "rh_col_started": "開始時刻",
     "rh_col_duration": "所要時間",
     "rh_col_status": "ステータス",

je_auto_control/utils/accessibility/backends/__init__.py

@@ -1,5 +1,6 @@
 """Platform backends for the accessibility API."""
 import sys
+from typing import Optional
 
 from je_auto_control.utils.accessibility.backends.base import (
     AccessibilityBackend,
@@ -8,7 +9,7 @@
     NullAccessibilityBackend,
 )
 
-_cached_backend: AccessibilityBackend = None  # type: ignore[assignment]
+_cached_backend: Optional[AccessibilityBackend] = None
 
 
 def get_backend() -> AccessibilityBackend:
@@ -23,7 +24,7 @@ def get_backend() -> AccessibilityBackend:
 def reset_backend_cache() -> None:
     """Force the next ``get_backend()`` call to re-detect."""
     global _cached_backend
-    _cached_backend = None  # type: ignore[assignment]
+    _cached_backend = None
 
 
 def _build_backend() -> AccessibilityBackend:

je_auto_control/utils/accessibility/backends/macos_backend.py

@@ -40,7 +40,7 @@ def list_elements(self, app_name: Optional[str] = None,
                 "pyobjc (ApplicationServices, AppKit) is required for "
                 "macOS accessibility",
             )
-        import ApplicationServices as AS
+        import ApplicationServices as ax_module
         import AppKit
 
         workspace = AppKit.NSWorkspace.sharedWorkspace()
@@ -54,8 +54,8 @@ def list_elements(self, app_name: Optional[str] = None,
                 continue
             pid = int(app.processIdentifier())
             try:
-                root = AS.AXUIElementCreateApplication(pid)
-                self._walk(AS, root, name, pid, results, max_results)
+                root = ax_module.AXUIElementCreateApplication(pid)
+                self._walk(ax_module, root, name, pid, results, max_results)
             except Exception as error:  # noqa: BLE001  # reason: AX errors vary
                 autocontrol_logger.warning(
                     "AX walk failed for %s (%d): %r", name, pid, error,
@@ -64,37 +64,37 @@ def list_elements(self, app_name: Optional[str] = None,
                 break
         return results[:max_results]
 
-    def _walk(self, AS, element, app_name: str, pid: int,
+    def _walk(self, ax_module, element, app_name: str, pid: int,
               results: List[AccessibilityElement], max_results: int) -> None:
         if len(results) >= max_results:
             return
-        converted = _convert_ax(AS, element, app_name, pid)
+        converted = _convert_ax(ax_module, element, app_name, pid)
         if converted is not None:
             results.append(converted)
-        err, children = AS.AXUIElementCopyAttributeValue(
+        err, children = ax_module.AXUIElementCopyAttributeValue(
             element, "AXChildren", None,
         )
         if err or children is None:
             return
         for child in children:
             if len(results) >= max_results:
                 return
-            self._walk(AS, child, app_name, pid, results, max_results)
+            self._walk(ax_module, child, app_name, pid, results, max_results)
 
 
-def _convert_ax(AS, element, app_name: str, pid: int,
+def _convert_ax(ax_module, element, app_name: str, pid: int,
                 ) -> Optional[AccessibilityElement]:
     try:
-        _err, role = AS.AXUIElementCopyAttributeValue(
+        _err, role = ax_module.AXUIElementCopyAttributeValue(
             element, "AXRole", None,
         )
-        _err, title = AS.AXUIElementCopyAttributeValue(
+        _err, title = ax_module.AXUIElementCopyAttributeValue(
             element, "AXTitle", None,
         )
-        _err, position = AS.AXUIElementCopyAttributeValue(
+        _err, position = ax_module.AXUIElementCopyAttributeValue(
             element, "AXPosition", None,
         )
-        _err, size = AS.AXUIElementCopyAttributeValue(
+        _err, size = ax_module.AXUIElementCopyAttributeValue(
             element, "AXSize", None,
         )
     except Exception:  # noqa: BLE001  # reason: AX errors vary

je_auto_control/utils/generate_report/generate_xml_report.py

@@ -1,7 +1,7 @@
 from threading import Lock
 from typing import Tuple, Union
 
-from defusedxml.minidom import parseString  # nosec B405  # reason: defusedxml is the safe replacement
+from defusedxml.minidom import parseString  # nosec B405  # nosemgrep: python.lang.security.use-defused-xml.use-defused-xml  # reason: defusedxml is the safe replacement
 
 from je_auto_control.utils.generate_report.generate_json_report import generate_json
 from je_auto_control.utils.logging.logging_instance import autocontrol_logger

je_auto_control/utils/hotkey/backends/linux_backend.py

@@ -89,47 +89,61 @@ def run_forever(self, context: BackendContext) -> None:
             disp.close()
 
     def _sync(self, disp, root, bindings: List[HotkeyBinding]) -> None:
-        from Xlib import X
-
         current_ids = {b.binding_id for b in bindings}
-        for stale in [bid for bid in self._registered if bid not in current_ids]:
-            _combo, mask, keycode = self._registered.pop(stale)
-            for extra_mask in _lock_mask_variants():
-                try:
-                    root.ungrab_key(keycode, mask | extra_mask)
-                except Exception:  # nosec B110  # noqa: BLE001  # reason: X11 ungrab races are non-fatal
-                    pass
+        self._ungrab_stale(root, current_ids)
         for binding in bindings:
-            prior = self._registered.get(binding.binding_id)
-            if prior is not None and prior[0] == binding.combo:
-                continue
-            if prior is not None:
-                self._registered.pop(binding.binding_id, None)
+            self._sync_one(root, binding)
+        disp.sync()
+
+    def _ungrab_stale(self, root, current_ids: set) -> None:
+        stale_ids = [bid for bid in self._registered if bid not in current_ids]
+        for stale in stale_ids:
+            _combo, mask, keycode = self._registered.pop(stale)
+            self._ungrab_masked(root, keycode, mask)
+
+    def _sync_one(self, root, binding: HotkeyBinding) -> None:
+        prior = self._registered.get(binding.binding_id)
+        if prior is not None and prior[0] == binding.combo:
+            return
+        if prior is not None:
+            self._registered.pop(binding.binding_id, None)
+        try:
+            mask, keycode = _combo_to_x11(binding.combo)
+        except ValueError as error:
+            autocontrol_logger.error(
+                "hotkey parse failed for %s: %r", binding.combo, error,
+            )
+            return
+        if self._grab_masked(root, binding, mask, keycode):
+            self._registered[binding.binding_id] = (
+                binding.combo, mask, keycode,
+            )
+
+    @staticmethod
+    def _ungrab_masked(root, keycode: int, mask: int) -> None:
+        for extra_mask in _lock_mask_variants():
             try:
-                mask, keycode = _combo_to_x11(binding.combo)
-            except ValueError as error:
-                autocontrol_logger.error(
-                    "hotkey parse failed for %s: %r", binding.combo, error,
+                root.ungrab_key(keycode, mask | extra_mask)
+            except Exception:  # nosec B110  # noqa: BLE001  # reason: X11 ungrab races are non-fatal
+                pass
+
+    @staticmethod
+    def _grab_masked(root, binding: HotkeyBinding,
+                     mask: int, keycode: int) -> bool:
+        from Xlib import X
+
+        for extra_mask in _lock_mask_variants():
+            try:
+                root.grab_key(
+                    keycode, mask | extra_mask, True,
+                    X.GrabModeAsync, X.GrabModeAsync,
                 )
-                continue
-            ok = True
-            for extra_mask in _lock_mask_variants():
-                try:
-                    root.grab_key(
-                        keycode, mask | extra_mask, True,
-                        X.GrabModeAsync, X.GrabModeAsync,
-                    )
-                except Exception as error:  # noqa: BLE001  # reason: X errors
-                    autocontrol_logger.error(
-                        "XGrabKey failed for %s: %r", binding.combo, error,
-                    )
-                    ok = False
-                    break
-            if ok:
-                self._registered[binding.binding_id] = (
-                    binding.combo, mask, keycode,
+            except Exception as error:  # noqa: BLE001  # reason: X errors
+                autocontrol_logger.error(
+                    "XGrabKey failed for %s: %r", binding.combo, error,
                 )
-        disp.sync()
+                return False
+        return True
 
     def _drain(self, disp, fire: "callable") -> None:
         from Xlib import X

je_auto_control/utils/hotkey/backends/windows_backend.py

@@ -47,7 +47,7 @@ def run_forever(self, context: BackendContext) -> None:
                         self._dispatch(msg.wParam, context.fire)
                 context.stop_event.wait(0.05)
         finally:
-            for reg_id, _ in list(self._registered.values()):
+            for reg_id, _ in self._registered.values():
                 user32.UnregisterHotKey(None, reg_id)
             self._registered.clear()
 

je_auto_control/utils/hotkey/hotkey_daemon.py

@@ -148,9 +148,7 @@ def list_bindings(self) -> List[HotkeyBinding]:
         with self._lock:
             return list(self._bindings.values())
 
-    def _snapshot(self) -> List[HotkeyBinding]:
-        with self._lock:
-            return list(self._bindings.values())
+    _snapshot = list_bindings
 
     def start(self) -> None:
         if self._thread is not None and self._thread.is_alive():