Skip to content

Commit fcd61b4

Browse files
committed
Stop je_auto_control_dev shadowing the editable install in CI
The previous quality.yml step ran: pip install -r dev_requirements.txt pip install -e . dev_requirements.txt's first line is `je_auto_control_dev` (a separate PyPI package), which ships an OLDER snapshot of the `je_auto_control/` tree directly into site-packages. Because that snapshot predates the rounds 22-47 work it lacks `utils/admin`, `utils/usb`, `utils/remote_desktop`, `utils/vision` and friends. When `pip install -e .` follows, the editable .pth + finder land in site-packages, but Python's import resolution still finds the masking on-disk `je_auto_control/` first — so every `import je_auto_control.utils.<new>` raises ModuleNotFoundError at test-collection time. Fix: pin quality.yml to install only what it actually needs: the editable package + ruff/bandit/pytest/pytest-timeout/PySide6. The legacy dev/stable workflows still use dev_requirements.txt for their integration coverage; this change only narrows the quality job's footprint.
1 parent 3696152 commit fcd61b4

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

.github/workflows/quality.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,16 @@ jobs:
7272
- name: Install dependencies
7373
run: |
7474
python -m pip install --upgrade pip wheel
75-
pip install -r dev_requirements.txt
75+
# Install the editable package FIRST so its source dir is the
76+
# one Python sees on subsequent imports. We deliberately
77+
# avoid `pip install -r dev_requirements.txt` here because
78+
# that file pulls in `je_auto_control_dev` (a separate PyPI
79+
# package), which ships its own snapshot of `je_auto_control/`
80+
# straight into site-packages and masks the editable install
81+
# for any sub-package the snapshot doesn't include
82+
# (admin, usb, remote_desktop, vision, …).
7683
pip install -e .
84+
pip install ruff==0.15.9 bandit==1.9.4 pytest==9.0.2 pytest-timeout==2.4.0 PySide6==6.11.0
7785
7886
- name: Run headless pytest suite
7987
run: pytest test/unit_test/headless/ -v --tb=short --timeout=120

0 commit comments

Comments
 (0)