Skip to content

Commit 9e5e6ea

Browse files
committed
remove w/a in SyclPlatform.get_devices
1 parent 2216d6b commit 9e5e6ea

2 files changed

Lines changed: 11 additions & 7 deletions

File tree

dpctl/_sycl_platform.pyx

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -415,19 +415,27 @@ cdef class SyclPlatform(_SyclPlatform):
415415
DTy = _device_type._ACCELERATOR
416416
elif dty_str == "all":
417417
DTy = _device_type._ALL_DEVICES
418+
elif dty_str == "automatic":
419+
DTy = _device_type._AUTOMATIC
418420
elif dty_str == "cpu":
419421
DTy = _device_type._CPU
422+
elif dty_str == "custom":
423+
DTy = _device_type._CUSTOM
420424
elif dty_str == "gpu":
421425
DTy = _device_type._GPU
422426
else:
423427
DTy = _device_type._UNKNOWN_DEVICE
424428
elif isinstance(device_type, device_type_t):
425-
if device_type == device_type_t.all:
426-
DTy = _device_type._ALL_DEVICES
427-
elif device_type == device_type_t.accelerator:
429+
if device_type == device_type_t.accelerator:
428430
DTy = _device_type._ACCELERATOR
431+
elif device_type == device_type_t.all:
432+
DTy = _device_type._ALL_DEVICES
433+
elif device_type == device_type_t.automatic:
434+
DTy = _device_type._AUTOMATIC
429435
elif device_type == device_type_t.cpu:
430436
DTy = _device_type._CPU
437+
elif device_type == device_type_t.custom:
438+
DTy = _device_type._CUSTOM
431439
elif device_type == device_type_t.gpu:
432440
DTy = _device_type._GPU
433441
else:

libsyclinterface/source/dpctl_sycl_platform_interface.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -300,10 +300,6 @@ DPCTLPlatform_GetDevices(__dpctl_keep const DPCTLSyclPlatformRef PRef,
300300
return nullptr;
301301
}
302302

303-
// handle unknown device
304-
// custom and automatic are also treated as unknown
305-
// as DPC++ would normally treat as `all`
306-
// see CMPLRLLVM-65826
307303
if (DTy == DPCTLSyclDeviceType::DPCTL_UNKNOWN_DEVICE) {
308304
return wrap<vecTy>(DevicesVectorPtr);
309305
}

0 commit comments

Comments
 (0)