From 083636e64b6aaba4e62ae0309dc455e29da54e91 Mon Sep 17 00:00:00 2001
From: Dominique <dominique.orban@gmail.com>
Date: Fri, 13 Feb 2026 15:04:10 -0500
Subject: [PATCH] add extra vector of storage inside QN models

The objective of this change is to move the QN updates to a callback
instead of having it performed in a generic manner by the solver.
This will allow for customized QN updates.
---
 src/quasi-newton.jl | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/quasi-newton.jl b/src/quasi-newton.jl
index 5d11857b..31760347 100644
--- a/src/quasi-newton.jl
+++ b/src/quasi-newton.jl
@@ -19,6 +19,7 @@ mutable struct LBFGSModel{
   meta::Meta
   model::M
   op::Op
+  v::S  # extra vector to compute and store yₖ = ∇fₖ₊₁ - ∇fₖ
 end
 
 mutable struct LSR1Model{
@@ -31,6 +32,7 @@ mutable struct LSR1Model{
   meta::Meta
   model::M
   op::Op
+  v::S  # extra vector to compute and store yₖ = ∇fₖ₊₁ - ∇fₖ
 end
 
 mutable struct DiagonalQNModel{
@@ -48,13 +50,15 @@ end
 "Construct a `LBFGSModel` from another type of model."
 function LBFGSModel(nlp::AbstractNLPModel{T, S}; kwargs...) where {T, S}
   op = LBFGSOperator(T, nlp.meta.nvar; kwargs...)
-  return LBFGSModel{T, S, typeof(nlp), typeof(nlp.meta), typeof(op)}(nlp.meta, nlp, op)
+  v = similar(nlp.meta.x0)
+  return LBFGSModel{T, S, typeof(nlp), typeof(nlp.meta), typeof(op)}(nlp.meta, nlp, op, v)
 end
 
 "Construct a `LSR1Model` from another type of nlp."
 function LSR1Model(nlp::AbstractNLPModel{T, S}; kwargs...) where {T, S}
   op = LSR1Operator(T, nlp.meta.nvar; kwargs...)
-  return LSR1Model{T, S, typeof(nlp), typeof(nlp.meta), typeof(op)}(nlp.meta, nlp, op)
+  v = similar(nlp.meta.x0)
+  return LSR1Model{T, S, typeof(nlp), typeof(nlp.meta), typeof(op)}(nlp.meta, nlp, op, v)
 end
 
 """