From 9a3554fa5b2831cea58fd898d6ea074bb0cf7bee Mon Sep 17 00:00:00 2001
From: Dimitris Dafnis <68849116+jim-daf@users.noreply.github.com>
Date: Thu, 23 Apr 2026 11:43:23 +0200
Subject: [PATCH] docs(DefaultWebClient): note that favicon may be null (#490)

---
 .../src/main/java/com/just/agentweb/DefaultWebClient.java     | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/agentweb-core/src/main/java/com/just/agentweb/DefaultWebClient.java b/agentweb-core/src/main/java/com/just/agentweb/DefaultWebClient.java
index fcbaa979..05f880b4 100755
--- a/agentweb-core/src/main/java/com/just/agentweb/DefaultWebClient.java
+++ b/agentweb-core/src/main/java/com/just/agentweb/DefaultWebClient.java
@@ -456,6 +456,10 @@ private boolean handleCommonLink(String url) {
 
 	@Override
 	public void onPageStarted(WebView view, String url, Bitmap favicon) {
+		// Issue #490: Some sites (notably Kotlin overrides) crashed because
+		// favicon arrived as null and downstream code dereferenced it. The
+		// platform contract is that favicon is nullable; AgentWeb itself never
+		// touches it without a null check below.
 		if (!mWaittingFinishSet.contains(url)) {
 			mWaittingFinishSet.add(url);
 		}