Skip to content

The on part of a join doesn't allow string values because they conflict with column names #369

@spl1nes

Description

@spl1nes

File: phpOMS/DataStorage/Database/Query/Grammar/Grammar.php

if (isset($element['value'])) {
  $expression .= ' ' . \strtoupper($element['operator']) . ' '
      . (\is_string($element['value']) ? $this->compileSystem($element['value']) : $element['value']);
}

Other data types are possible because they don't conflict with the data type of columns (string)
Consider to create a ColumnName() class.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions