From 841dd1377d8833ae9958959a72819242d59636a3 Mon Sep 17 00:00:00 2001 From: Brian Hill Date: Wed, 4 Mar 2026 12:43:53 -0500 Subject: [PATCH 1/2] fixed sans passed as extension data --- GCPCAS/Client/CreateCertificateRequestBuilder.cs | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/GCPCAS/Client/CreateCertificateRequestBuilder.cs b/GCPCAS/Client/CreateCertificateRequestBuilder.cs index 86b42b8..22f587f 100644 --- a/GCPCAS/Client/CreateCertificateRequestBuilder.cs +++ b/GCPCAS/Client/CreateCertificateRequestBuilder.cs @@ -1,5 +1,5 @@ /* -Copyright © 2025 Keyfactor +Copyright � 2025 Keyfactor Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. @@ -85,12 +85,14 @@ public ICreateCertificateRequestBuilder WithEnrollmentProductInfo(EnrollmentProd string base64Value = param.Value; _logger.LogTrace($"Loggin oid and value {oid} {base64Value}"); - - var extension = CreateX509Extension(oid, base64Value); - if (extension != null) + if (oid != "2.5.29.17") //can't send Sans as an extension to google, they do not like this and you will get an error { - _logger.LogTrace($"Adding Extension"); - _additionalExtensions.Add(extension); + var extension = CreateX509Extension(oid, base64Value); + if (extension != null) + { + _logger.LogTrace($"Adding Extension"); + _additionalExtensions.Add(extension); + } } } } From b9ef7b6249f6ccbc8df7c67cc0665acb8a656a1c Mon Sep 17 00:00:00 2001 From: Brian Hill <76450501+bhillkeyfactor@users.noreply.github.com> Date: Wed, 4 Mar 2026 13:00:00 -0500 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2525ce1..be5f67f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,5 @@ +- 1.2.3 + - Fixed Sans Being passed through Extensions Data, Google does not like this. - 1.2.2 - Fixed Sync Issues at CA Level, was ignoring and always syncing at pool level - 1.2.1