refactor(cloud-agent-next): use message-based queued execution#3383
Open
eshurakov wants to merge 5 commits into
Open
refactor(cloud-agent-next): use message-based queued execution#3383eshurakov wants to merge 5 commits into
eshurakov wants to merge 5 commits into
Conversation
Contributor
Code Review SummaryStatus: 2 Issues Remaining | Recommendation: Can merge; carried-forward items are low-risk Executive SummaryThe three new commits ( Overview
Issue Details (click to expand)WARNING (carried forward — unchanged)
SUGGESTION (carried forward — unchanged)
Resolved in this round
New changes reviewed (commits since 1532be0)
Files ReviewedNew in this round:
Carried forward (unchanged):
Fix these issues in Kilo Cloud Reviewed by claude-4.6-sonnet-20260217 · 1,983,115 tokens Review guidance: REVIEW.md from base branch |
eshurakov
force-pushed
the
eshurakov/diamond-storm
branch
from
9670177 to
ab795d7
Compare
eshurakov
force-pushed
the
eshurakov/diamond-storm
branch
from
bdeaa03 to
e2dbe6e
Compare
RSO
approved these changes
May 22, 2026
| prompt: rs?.prompt ?? null, | ||
| initialMessageId: rs?.initialMessageId ?? null, | ||
| associatedPr: sessionResult.associatedPr, | ||
| associatedPr: null, |
Contributor
There was a problem hiding this comment.
Why are we setting associatedPr to always be null?
| label: 'Queued' | 'Failed to deliver'; | ||
| tone: 'info' | 'error'; | ||
| title?: string; | ||
| }; |
Contributor
There was a problem hiding this comment.
Sounds like this should be:
export type DeliveryBadge =
| {
label: 'Queued';
tone: 'info';
title?: string;
}
| {
label: 'Failed to deliver';
tone: 'error';
title?: string;
};
Comment on lines
+220
to
+231
| if (metadata.githubRepo) { | ||
| return { | ||
| type: 'github', | ||
| repo: metadata.githubRepo, | ||
| ...omitUndefined({ | ||
| platform: metadata.platform === 'github' ? 'github' : undefined, | ||
| githubInstallationId: metadata.githubInstallationId, | ||
| githubAppType: metadata.githubAppType, | ||
| upstreamBranch: metadata.upstreamBranch, | ||
| }), | ||
| }; | ||
| } |
Contributor
There was a problem hiding this comment.
Should this also still support the legacy githubToken attribute?
Comment on lines
+248
to
+257
| const payload: CallbackJob['payload'] = { | ||
| sessionId, | ||
| cloudAgentSessionId: sessionId, | ||
| status, | ||
| errorMessage: error, | ||
| lastSeenBranch: metadata.repository?.upstreamBranch, | ||
| kiloSessionId: metadata.auth.kiloSessionId, | ||
| gateResult, | ||
| lastAssistantMessageText, | ||
| }; |
Contributor
There was a problem hiding this comment.
I have zero clue about this one, but I figure that you will:
enqueueCallbackNotificationbuilds the legacy callback payload withoutexecutionId(services/cloud-agent-next/src/persistence/CloudAgentSession.ts:248), but the security-analysis callback still requires it (apps/web/src/app/api/internal/security-analysis-callback/[findingId]/route.ts:42). Old execution-id-only terminal paths can complete but have callbacks rejected. IncludeexecutionId: messageId ??execution.executionId.
Preserve callback and pending-message state through queue failures, keep legacy execution callback compatibility explicit during rollout, and tighten wrapper reconnect/lifecycle cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Reviewer Notes
messageIdbecomes the durable delivery/settlement key, withexecutionIdretained only where legacy response compatibility requires it.getSessionintentionally keeps callback targets redacted; stored callback metadata remains internal for outbox delivery and may contain service-to-service headers.