fix(gastown): tag structured logs with town IDs#3428
Open
evanjacobson wants to merge 1 commit into
Open
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryAll Files Reviewed (11 files)
Reviewer Notes
Reviewed by claude-sonnet-4.6 · 736,918 tokens Review guidance: REVIEW.md from base branch |
jrf0110
approved these changes
May 22, 2026
b5e8679 to
c8d2aa9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gastown logs were hard to correlate across worker, Durable Object, container, plugin, and tRPC paths because several structured logging sites did not include the town identifier even when it was available.
This adds town ID tagging to the structured logging paths that can derive it, following the existing
workers-tagged-loggercontext pattern in the worker and the container logger/app-log payload conventions in container code.Implementation notes
townId.townIdfields to container process logs where the town is available from env, request, or agent state.extrapayload.Verification
Not manually tested; this is an observability-only logging change.
Visual Changes
N/A
Reviewer Notes
Review focus: confirm each new
townIdsource matches the relevant request, agent, or container scope.