From 85ea3f2af3e49905aca93587a28994ed19dad5ab Mon Sep 17 00:00:00 2001 From: romleiaj Date: Thu, 20 Aug 2026 13:52:47 -0400 Subject: [PATCH 1/8] Hide the sidebar on registration open regardless of which side it is on The collapse only fired for the left sidebar, so opening Camera Registration with the sidebar in bottom mode left it up, competing for the vertical room the two picking panes need. Collapse it either way; the prior mode is still restored on close and the toggle still works while registering. Co-Authored-By: Claude Fable 5 Claude-Session: https://claude.ai/code/session_01K9imLktmzCkAR3wmUybaEs --- client/dive-common/components/Viewer.vue | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/client/dive-common/components/Viewer.vue b/client/dive-common/components/Viewer.vue index cbc470dd8..33e7a4a1c 100644 --- a/client/dive-common/components/Viewer.vue +++ b/client/dive-common/components/Viewer.vue @@ -333,20 +333,20 @@ export default defineComponent({ const showUserSettingsDialog = ref(false); // When the Camera Registration panel opens, minimize the workspace chrome - // to give the picking view more room: collapse the left type-filter - // sidebar. The bottom controls deliberately stay as they are -- the - // timeline hosts the registration-frame marker row, which is most useful - // exactly while this panel is open. This is a soft default -- the normal - // sidebar toggle still works while registering -- and whatever layout the - // user had before is restored on close. + // to give the picking view more room: hide the type-filter sidebar, + // whichever side it is on. Bottom especially -- it competes for the same + // vertical room the two picking panes want. The bottom controls + // deliberately stay as they are -- the timeline hosts the + // registration-frame marker row, which is most useful exactly while this + // panel is open. This is a soft default -- the normal sidebar toggle + // still works while registering -- and whatever layout the user had + // before is restored on close. const registrationActive = computed(() => context.state.active === RegistrationToolsVue.name); let preRegistrationSidebarMode: 'left' | 'bottom' | 'collapsed' | null = null; watch(registrationActive, (active) => { if (active) { preRegistrationSidebarMode = sidebarMode.value; - if (sidebarMode.value === 'left') { - sidebarMode.value = 'collapsed'; - } + sidebarMode.value = 'collapsed'; } else if (preRegistrationSidebarMode !== null) { sidebarMode.value = preRegistrationSidebarMode; preRegistrationSidebarMode = null; From 0555ceddb3380093875cdc767d9741fe56af1c1c Mon Sep 17 00:00:00 2001 From: romleiaj Date: Thu, 20 Aug 2026 14:08:02 -0400 Subject: [PATCH 2/8] Don't offer the sidebar toggle while the registration panel is open The sidebar isn't useful during picking and the bottom layout in particular doesn't lay the picking panes out usably. The panel already collapses the sidebar on open and restores it on close; hide the toggle in between so it can't be turned back on there. Co-Authored-By: Claude Fable 5 Claude-Session: https://claude.ai/code/session_01K9imLktmzCkAR3wmUybaEs --- client/dive-common/components/Viewer.vue | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/client/dive-common/components/Viewer.vue b/client/dive-common/components/Viewer.vue index 33e7a4a1c..6897cdf84 100644 --- a/client/dive-common/components/Viewer.vue +++ b/client/dive-common/components/Viewer.vue @@ -2372,6 +2372,7 @@ export default defineComponent({ cycleSidebarMode, sidebarModeIcon, sidebarModeTooltip, + registrationActive, bottomRightPanelView, toggleBottomRightPanel, colorBy, @@ -2543,7 +2544,14 @@ export default defineComponent({