From d7e58d90b21e58db38e9233f37998ae727852128 Mon Sep 17 00:00:00 2001 From: Jonathan Date: Wed, 4 Aug 2021 13:28:41 +0100 Subject: [PATCH 1/3] Fixed: Bug, #196 permissions reset when creating rfr Signed-off-by: Jonathan --- cogs/ReactForRole.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cogs/ReactForRole.py b/cogs/ReactForRole.py index 34a20ff6..1ecccf52 100644 --- a/cogs/ReactForRole.py +++ b/cogs/ReactForRole.py @@ -937,10 +937,11 @@ async def overwrite_channel_add_reaction_perms(self, guild: discord.Guild, chann """ # Get the @everyone role. role: discord.Role = discord.utils.get(guild.roles, id=guild.id) - overwrite: discord.PermissionOverwrite = discord.PermissionOverwrite() - overwrite.update(add_reactions=False) - await channel.set_permissions(role, overwrite=overwrite) + perms = channel.overwrites_for(role) + perms.add_reactions = False + await channel.set_permissions(role, overwrite=perms) bot_members = [member for member in guild.members if member.bot and member.id == self.bot.user.id] + overwrite: discord.PermissionOverwrite = discord.PermissionOverwrite() overwrite.update(add_reactions=True) for bot_member in bot_members: await channel.set_permissions(bot_member, overwrite=overwrite) From bf4a27ac697a6898548d3d7d5b5bbb237510275f Mon Sep 17 00:00:00 2001 From: Jonathan Date: Wed, 4 Aug 2021 13:35:23 +0100 Subject: [PATCH 2/3] feat: added change to CHANGELOG Signed-off-by: Jonathan --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 72e2a29d..a437e1ac 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ All notable changes to KoalaBot will be documented in this file. A lot of these commands will only be available to administrators ## [Unreleased] +- Fixed issues with permissions for a text channel resetting when a react for role is created. ### Other - Testing updated to use builders in dpytest 0.5.0 From 781bcdef3d187e7ee6a5ec57151cd83d0f9a991f Mon Sep 17 00:00:00 2001 From: Kaspiaan Date: Wed, 20 Oct 2021 04:09:23 +0100 Subject: [PATCH 3/3] Changed line as perms.add_reactions = False is not valid --- cogs/ReactForRole.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cogs/ReactForRole.py b/cogs/ReactForRole.py index c86a8465..cba0d15c 100644 --- a/cogs/ReactForRole.py +++ b/cogs/ReactForRole.py @@ -943,7 +943,7 @@ async def overwrite_channel_add_reaction_perms(self, guild: discord.Guild, chann # Get the @everyone role. role: discord.Role = discord.utils.get(guild.roles, id=guild.id) perms = channel.overwrites_for(role) - perms.add_reactions = False + perms.update(add_reactions=False) await channel.set_permissions(role, overwrite=perms) bot_members = [member for member in guild.members if member.bot and member.id == self.bot.user.id] overwrite: discord.PermissionOverwrite = discord.PermissionOverwrite()