detekt

Author: Mr3zee

gradle-plugin/src/main/kotlin/kotlinx/rpc/buf/tasks/GenerateBufGenYaml.kt

@@ -140,7 +140,11 @@ internal fun Project.registerGenerateBufGenYamlTask(
     configure: GenerateBufGenYaml.() -> Unit = {},
 ): TaskProvider<GenerateBufGenYaml> {
     val capitalizeName = name.replaceFirstChar { it.uppercase() }
-    val task = project.tasks.register("${GenerateBufGenYaml.NAME_PREFIX}$capitalizeName", GenerateBufGenYaml::class, properties)
+    val task = project.tasks.register(
+        "${GenerateBufGenYaml.NAME_PREFIX}$capitalizeName",
+        GenerateBufGenYaml::class,
+        properties,
+    )
 
     task.configure {
         val pluginsProvider = project.provider {

gradle-plugin/src/main/kotlin/kotlinx/rpc/protoc/DefaultProtoSourceSet.kt

@@ -175,15 +175,13 @@ internal open class DefaultProtoSourceSet(
             return
         }
 
-        if (this == protoSourceSet) {
-            throw IllegalArgumentException("$name proto source set cannot extend from self")
+        require(this != protoSourceSet) {
+            "$name proto source set cannot extend from self"
         }
 
-        if (protoSourceSet !is DefaultProtoSourceSet) {
-            throw IllegalArgumentException(
-                "$name proto source set can only extend from other default proto source sets." +
-                        "${protoSourceSet.name} is not a ${DefaultProtoSourceSet::class.simpleName}",
-            )
+        require(protoSourceSet is DefaultProtoSourceSet) {
+            "$name proto source set can only extend from other default proto source sets." +
+                    "${protoSourceSet.name} is not a ${DefaultProtoSourceSet::class.simpleName}"
         }
 
         extendsFrom += protoSourceSet
@@ -209,8 +207,8 @@ internal open class DefaultProtoSourceSet(
     }
 
     private fun ProtoSourceSet.checkSelfImport(): ProtoSourceSet {
-        if (this@DefaultProtoSourceSet == this) {
-            throw IllegalArgumentException("${this@DefaultProtoSourceSet.name} proto source set cannot import from itself")
+        require(this@DefaultProtoSourceSet != this) {
+            "${this@DefaultProtoSourceSet.name} proto source set cannot import from itself"
         }
 
         return this

gradle-plugin/src/main/kotlin/kotlinx/rpc/protoc/DefaultProtocExtension.kt

@@ -336,7 +336,8 @@ internal open class DefaultProtocExtension @Inject constructor(
             languageSets.filterIsInstance<AndroidSourceSet>().forEach { sourceSet ->
                 // todo fails with
                 //
-                // Caused by: org.gradle.internal.typeconversion.UnsupportedNotationException: Cannot convert the provided notation to a File: [].
+                // Caused by: org.gradle.internal.typeconversion.UnsupportedNotationException:
+                // Cannot convert the provided notation to a File: [].
                 // The following types/formats are supported:
                 //   - A String or CharSequence path, for example 'src/main/java' or '/usr/include'.
                 //   - A String or CharSequence URI, for example 'file:/usr/include'.
@@ -366,6 +367,7 @@ internal open class DefaultProtocExtension @Inject constructor(
         }
     }
 
+    @Suppress("detekt.LongParameterList")
     private fun configureCustomTasks(
         protoSourceSet: DefaultProtoSourceSet,
         buildSourceSetsDir: File,
@@ -441,7 +443,9 @@ internal open class DefaultProtocExtension @Inject constructor(
         }
     }
 
-    private fun DefaultProtoSourceSet.getDependsOnImports(protoSourceSets: ProtoSourceSets): Provider<List<ProtoSourceSet>> {
+    private fun DefaultProtoSourceSet.getDependsOnImports(
+        protoSourceSets: ProtoSourceSets,
+    ): Provider<List<ProtoSourceSet>> {
         return languageSourceSets.map { list ->
             val kotlin = list.filterIsInstance<KotlinSourceSet>()
 
@@ -564,6 +568,7 @@ private fun Project.configureMultiplatformWithAndroidSourceSets(body: (DefaultPr
         }
 }
 
+@Suppress("detekt.CyclomaticComplexMethod")
 private fun AndroidComponents.configureLegacyAndroidVariants(
     project: Project,
     isKmp: Boolean,
@@ -603,7 +608,9 @@ private fun AndroidComponents.configureLegacyAndroidVariants(
             // but testFixtures still have source sets based on flavors
             val testFixtureSetNames = if (rootName != LegacyAndroidRootSourceSets.Main) {
                 variant.dependencySourceSets(LegacyAndroidRootSourceSets.TestFixtures)
-            } else emptyList()
+            } else {
+                emptyList()
+            }
 
             val dependencySourceSetNames = variant.dependencySourceSets(rootName)
             val variantSourceSetName = dependencySourceSetNames.lastOrNull()

gradle-plugin/src/main/kotlin/kotlinx/rpc/protoc/ProtoTask.kt

@@ -30,7 +30,8 @@ public interface ProtoTask : Task {
          *
          * For Kotlin/JVM it has only one source set (`main`, or `test`, for example).
          *
-         * For Kotlin/Multiplatform it also has only one source set (`commonMain`, `commonTest`, or `jsMain`, for example).
+         * For Kotlin/Multiplatform it also has only one source set
+         * (`commonMain`, `commonTest`, or `jsMain`, for example).
          *
          * For Android, Kotlin/Android, and Kotlin/Multiplatform + Android it can have multiple source sets:
          * - `["androidMain", "androidDebug", "main", "debug"]`

gradle-plugin/src/main/kotlin/kotlinx/rpc/protoc/ProtoTasks.kt

@@ -257,7 +257,9 @@ internal open class ProtoTasksImpl<ProtoTaskT : ProtoTask>(
         return matchingSourceSet(sourceSet.name)
     }
 
-    override fun matchingKotlinSourceSet(sourceSet: NamedDomainObjectProvider<KotlinSourceSet>): ProtoTasks<ProtoTaskT> {
+    override fun matchingKotlinSourceSet(
+        sourceSet: NamedDomainObjectProvider<KotlinSourceSet>,
+    ): ProtoTasks<ProtoTaskT> {
         return matchingSourceSet(sourceSet.name)
     }
 

gradle-plugin/src/main/kotlin/kotlinx/rpc/protoc/android/variants.kt

@@ -89,7 +89,9 @@ internal fun String.kotlinProxyFromAndroidOriginSourceSetName(rootName: LegacyAn
             "androidInstrumented${removePrefix("android").replaceFirstChar { it.uppercase() }}"
         }
 
-        LegacyAndroidRootSourceSets.TestFixtures -> null
+        LegacyAndroidRootSourceSets.TestFixtures -> {
+            null
+        }
     }
 }
 

gradle-plugin/src/main/kotlin/kotlinx/rpc/util/kgp.kt

@@ -88,7 +88,9 @@ internal fun Project.withLegacyAndroid(action: LegacyAndroidApplied.() -> Unit)
 
 internal class LegacyAndroidApplied(val project: Project, val id: String)
 
-internal fun LegacyAndroidApplied.withAndroidSourceSets(action: (NamedDomainObjectContainer<out AndroidSourceSet>) -> Unit) {
+internal fun LegacyAndroidApplied.withAndroidSourceSets(
+    action: (NamedDomainObjectContainer<out AndroidSourceSet>) -> Unit,
+) {
     action(project.the<BaseExtension>().sourceSets)
 }
 

gradle-plugin/src/test/kotlin/kotlinx/rpc/GrpcAndroidProjectTest.kt

@@ -2,6 +2,8 @@
  * Copyright 2023-2025 JetBrains s.r.o and contributors. Use of this source code is governed by the Apache 2.0 license.
  */
 
+@file:Suppress("detekt.LongMethod", "detekt.LargeClass")
+
 package kotlinx.rpc
 
 import kotlinx.rpc.base.GrpcBaseTest

gradle-plugin/src/test/kotlin/kotlinx/rpc/GrpcKmpProjectTest.kt

@@ -2,6 +2,8 @@
  * Copyright 2023-2025 JetBrains s.r.o and contributors. Use of this source code is governed by the Apache 2.0 license.
  */
 
+@file:Suppress("detekt.LongMethod", "detekt.LargeClass")
+
 package kotlinx.rpc
 
 import kotlinx.rpc.base.GrpcBaseTest

gradle-plugin/src/test/kotlin/kotlinx/rpc/base/GrpcBaseTest.kt

@@ -355,14 +355,20 @@ abstract class GrpcBaseTest : BaseTest() {
             extendedProto: List<SSets>,
         ) {
             if (!sourceSet.applicable()) {
-                println("Skipping ${sourceSet.capital} source set because it's not applicable for the current Kotlin version")
+                println(
+                    "Skipping ${sourceSet.capital} source set " +
+                            "because it's not applicable for the current Kotlin version"
+                )
                 return
             }
 
             val importsSet = imports
                 .onEach {
                     if (!it.applicable()) {
-                        println("Skipping ${it.capital} import source set because it's not applicable for the current Kotlin version")
+                        println(
+                            "Skipping ${it.capital} import source set " +
+                                    "because it's not applicable for the current Kotlin version"
+                        )
                     }
                 }
                 .filter { it.applicable() }
@@ -603,10 +609,16 @@ private val SSets.capital get() = name.replaceFirstChar { it.titlecase() }
 
 private fun SSets.compileTaskName(mode: CompileTaskMode): String {
     return when (mode) {
-        CompileTaskMode.Jvm -> if (name == "main") "compileKotlin" else "compileTestKotlin"
+        CompileTaskMode.Jvm -> {
+            if (name == "main") "compileKotlin" else "compileTestKotlin"
+        }
         CompileTaskMode.Kmp -> {
             val platform = capital.removeSuffix("Main").removeSuffix("Test")
-            if (name.endsWith("Test")) "compileTestKotlin$platform" else "compileKotlin$platform"
+            if (name.endsWith("Test")) {
+                "compileTestKotlin$platform"
+            } else {
+                "compileKotlin$platform"
+            }
         }
 
         CompileTaskMode.Android -> {
@@ -622,7 +634,9 @@ private fun SSets.compileTaskName(mode: CompileTaskMode): String {
                     "compile${name.removePrefix("test")}UnitTestKotlin"
                 }
 
-                else -> "compile${capital}Kotlin"
+                else -> {
+                    "compile${capital}Kotlin"
+                }
             }
         }
 
@@ -640,7 +654,9 @@ private fun SSets.compileTaskName(mode: CompileTaskMode): String {
                     "compile${withoutPrefix.removePrefix("UnitTest")}UnitTestKotlinAndroid"
                 }
 
-                else -> "compile${withoutPrefix}KotlinAndroid"
+                else -> {
+                    "compile${withoutPrefix}KotlinAndroid"
+                }
             }
         }