Skip to content

FOGD changing sign of Cosine instead of Sine #3

Description

@BillyBarbaro

FOGD includes an implementation of sine and cosine calculations using a method that's described in this blog post. The way it's implemented in FOGD, it seems like p1 is meant to represent the cosine and p2 the sine; however, looking at the formulas from the post (and computing the values on my own), this appears to be flipped, i.e. p1 is sine and p2 is cosine. This leads to a problem here where the sign of p2 is flipped if the angle of negative. This would be correct if p2 was sine, but is not correct since p2 is actually the cosine of the angle.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions