DUNE/Utils/String: fix rightTrimInPlace underflow on empty/all-ws input#291
Open
krisgry wants to merge 1 commit into
Open
DUNE/Utils/String: fix rightTrimInPlace underflow on empty/all-ws input#291krisgry wants to merge 1 commit into
krisgry wants to merge 1 commit into
Conversation
Empty strings made `r = str - 1` and the loop then read one byte before the buffer; all-whitespace strings walked off the front the same way. Caught by ASan via Parsers/Config::parseFile when getOptionAndValue returned rv==2 (key with no value) and arg was the empty string. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #290