Summary
The generate() method in packages/cnpj-gen/src/CnpjGenerator.php currently retries recursively when CnpjCheckDigits throws a CnpjCheckDigitsException. Since PHP does not optimize tail calls, a prefix/type combination that consistently produces sequences failing check-digit computation could exhaust the call stack without surfacing a meaningful error. Additionally, an unbounded retry could hide systemic failures (e.g., an upstream regression in CnpjCheckDigits) by silently looping indefinitely.
Relevant code (lines ~128–133)
try {
$cnpjCheckDigits = new CnpjCheckDigits($generatedCnpj);
$generatedCnpj = $cnpjCheckDigits->cnpj;
} catch (CnpjCheckDigitsException $e) {
return $this->generate($options, $format, $prefix, $type);
}Proposed direction
Replace the unbounded recursive retry with an iterative bounded retry (e.g., a for loop with a MAX_RETRIES constant). After exhausting all attempts, re-throw the last CnpjCheckDigitsException (or a new descriptive exception) so failures surface cleanly instead of silently looping or crashing with a stack overflow.
References
Summary
The
generate()method inpackages/cnpj-gen/src/CnpjGenerator.phpcurrently retries recursively whenCnpjCheckDigitsthrows aCnpjCheckDigitsException. Since PHP does not optimize tail calls, a prefix/type combination that consistently produces sequences failing check-digit computation could exhaust the call stack without surfacing a meaningful error. Additionally, an unbounded retry could hide systemic failures (e.g., an upstream regression inCnpjCheckDigits) by silently looping indefinitely.Relevant code (lines ~128–133)
Proposed direction
Replace the unbounded recursive retry with an iterative bounded retry (e.g., a
forloop with aMAX_RETRIESconstant). After exhausting all attempts, re-throw the lastCnpjCheckDigitsException(or a new descriptive exception) so failures surface cleanly instead of silently looping or crashing with a stack overflow.References
v2][cnpj-gen] Upgrade to latest API and add support to alphanumeric CNPJ format #39v2][cnpj-gen] Upgrade to latest API and add support to alphanumeric CNPJ format #39 (comment)