From 8325597297f92f3c753dc7e040f8b4396562a17c Mon Sep 17 00:00:00 2001
From: Myst <1592048+LeMyst@users.noreply.github.com>
Date: Sat, 6 Jun 2026 09:50:37 +0200
Subject: [PATCH] Add AnonymousEditError and improve error handling

Introduce AnonymousEditError for anonymous-edit attempts and import it in helpers. Replace generic Exception raised on anonymous token with AnonymousEditError and use MaxRetriesReachedException for SPARQL retry exhaustion. Keeps error semantics clearer and improves exception specificity.
---
 wikibaseintegrator/wbi_exceptions.py | 5 +++++
 wikibaseintegrator/wbi_helpers.py    | 8 ++++----
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/wikibaseintegrator/wbi_exceptions.py b/wikibaseintegrator/wbi_exceptions.py
index dd57a1f0..94e4a966 100644
--- a/wikibaseintegrator/wbi_exceptions.py
+++ b/wikibaseintegrator/wbi_exceptions.py
@@ -99,3 +99,8 @@ class MissingEntityException(Exception):
 
 class SearchError(Exception):
     pass
+
+
+class AnonymousEditError(Exception):
+    """Raised when an anonymous edit is attempted but allow_anonymous is False"""
+    pass
diff --git a/wikibaseintegrator/wbi_helpers.py b/wikibaseintegrator/wbi_helpers.py
index 18e86f7e..9575395e 100644
--- a/wikibaseintegrator/wbi_helpers.py
+++ b/wikibaseintegrator/wbi_helpers.py
@@ -17,7 +17,7 @@
 
 from wikibaseintegrator.wbi_backoff import wbi_backoff
 from wikibaseintegrator.wbi_config import config
-from wikibaseintegrator.wbi_exceptions import MaxRetriesReachedException, ModificationFailed, MWApiError, NonExistentEntityError, SaveFailed, SearchError
+from wikibaseintegrator.wbi_exceptions import AnonymousEditError, MaxRetriesReachedException, ModificationFailed, MWApiError, NonExistentEntityError, SaveFailed, SearchError
 
 if TYPE_CHECKING:
     from wikibaseintegrator.datatypes import BaseDataType
@@ -201,8 +201,8 @@ def mediawiki_api_call_helper(data: dict[str, Any], login: _Login | None = None,
                     data.update({'assert': 'user'})
 
             if 'token' in data and data['token'] == '+\\':
-                raise Exception("Anonymous edit are not allowed by default. "
-                                "Set allow_anonymous to True to edit mediawiki anonymously or set the login parameter with a valid Login object.")
+                raise AnonymousEditError("Anonymous edit are not allowed by default. "
+                                         "Set allow_anonymous to True to edit mediawiki anonymously or set the login parameter with a valid Login object.")
         else:
             if 'assert' not in data and login is None:
                 # Assert anon if allow_anonymous is True and no Login instance
@@ -282,7 +282,7 @@ def execute_sparql_query(query: str, prefix: str | None = None, endpoint: str |
 
         return results
 
-    raise Exception(f"No result after {max_retries} retries.")
+    raise MaxRetriesReachedException(f"No result after {max_retries} retries.")
 
 
 def edit_entity(data: dict, id: str | None = None, type: str | None = None, baserevid: int | None = None, summary: str | None = None, clear: bool = False, is_bot: bool = False,