feat(settings): Azure and GCP create-override modal (closes #109)#588
feat(settings): Azure and GCP create-override modal (closes #109)#588cristim wants to merge 1 commit into
Conversation
Extend the per-account override create/edit flow to Azure and GCP accounts (previously AWS-only, tracked as follow-up to issue #104). - Drop `canCreate = provider === 'aws'` gate: all providers now render the "Add override" button and auto-open the create modal on empty state - Add AZURE_OVERRIDE_SERVICES and GCP_OVERRIDE_SERVICES lists; dispatch via getOverrideServicesForProvider so the service dropdown is provider-aware - Remove `o.provider === 'aws'` guards on term/payment/coverage table cells: all three get inline editing selects/inputs for every provider - Remove the disabled+tooltip guard on the enabled checkbox for non-AWS rows - buildPaymentOverrideSelect and syncOverridePaymentOptions now derive the fallback payment list from getCommitmentConfig(provider) instead of a hardcoded AWS-only constant, so Azure shows upfront/monthly and GCP shows monthly-only - Remove now-unused AWS_PAYMENT_OPTIONS constant (superseded by getCommitmentConfig which already owns the same data) - Tests: update three tests that asserted the old read-only behavior; add coverage for Azure payment options, Azure inline editing, and Azure empty-state modal auto-open with provider-correct service list
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
canCreate = provider === 'aws'gate inloadOverridesPanel; Azure and GCP accounts now get the "Add override" button and auto-open the create modal on empty stateAZURE_OVERRIDE_SERVICESandGCP_OVERRIDE_SERVICESlists;getOverrideServicesForProviderdispatches to the right list so the service dropdown is provider-awareo.provider === 'aws'inline-editing guards for Term, Payment, Coverage, and Enabled cells on existing override rowsgetCommitmentConfig(provider).paymentsas fallback; Azure shows upfront/monthly, GCP shows monthly-onlyAWS_PAYMENT_OPTIONSconstant (superseded bygetCommitmentConfig)Test plan
npx tsc --noEmitpassesnpx jestpasses (1897/1897)