fix(config): make SQL active-commitment expiry boundary inclusive

GetActivePurchaseHistory excluded a commitment expiring exactly at asOf
(`> $1`) while the API layer's isActiveCommitment treats that instant as
still active (!now.After(expiry)). Align the SQL predicate to `>= $1`
so both sides share one boundary definition, and document the inclusive
contract in the store and interface docstrings. The pgxmock tests pin
the new predicate.

Addresses CodeRabbit review on PR #1221 (store_postgres.go).

Author: cristim

internal/config/interfaces.go

@@ -122,7 +122,8 @@ type StoreInterface interface {
 	GetPurchaseHistory(ctx context.Context, accountID string, limit int) ([]PurchaseHistoryRecord, error)
 	GetAllPurchaseHistory(ctx context.Context, limit int) ([]PurchaseHistoryRecord, error)
 	// GetActivePurchaseHistory returns every purchase_history row whose commitment
-	// is still within its term at asOf (term > 0 AND timestamp + term years > asOf),
+	// is still within its term at asOf (term > 0 AND timestamp + term years >= asOf;
+	// the expiry boundary is inclusive, matching the API layer's isActiveCommitment),
 	// newest-first, optionally scoped to a set of accounts. The account scope uses
 	// the same dual-column predicate as GetPurchaseHistoryFiltered: accountIDs
 	// match cloud_account_id (cloud_accounts UUIDs) and externalIDsByProvider

internal/config/store_postgres.go

@@ -1626,11 +1626,14 @@ func (s *PostgresStore) GetAllPurchaseHistory(ctx context.Context, limit int) ([
 // it cannot silently truncate older-but-still-active 1y/3y commitments the way
 // a newest-first LIMIT page does (issue #1140). term*8760 hours matches the
 // collector's HoursPerYear and the API layer's commitmentExpiry (both 365*24)
-// so the SQL and Go term windows agree.
+// so the SQL and Go term windows agree. The expiry comparison is inclusive
+// (expiry >= asOf): a commitment expiring exactly at asOf is still active,
+// matching the API layer's isActiveCommitment (!now.After(expiry)) so the SQL
+// result set and the Go-side active checks share one boundary definition.
 func (s *PostgresStore) GetActivePurchaseHistory(ctx context.Context, asOf time.Time, accountIDs []string, externalIDsByProvider map[string][]string) ([]PurchaseHistoryRecord, error) {
 	conds := []string{
 		"term > 0",
-		"timestamp + make_interval(hours => term * 8760) > $1",
+		"timestamp + make_interval(hours => term * 8760) >= $1",
 	}
 	args := []any{asOf}
 	conds, args = appendAccountPredicate(conds, args, accountIDs, externalIDsByProvider)

internal/config/store_postgres_pgxmock_test.go

@@ -786,7 +786,9 @@ func TestPGXMock_GetPurchaseHistoryFiltered_NoFilters(t *testing.T) {
 // the active filter into the WHERE clause with NO LIMIT (the `$` anchor after
 // ORDER BY proves no trailing LIMIT clause), so the result is bounded by the
 // number of live commitments and a newest-first row cap can never silently
-// drop the oldest still-active 1y/3y commitments (issue #1140). It also pins
+// drop the oldest still-active 1y/3y commitments (issue #1140). The pinned
+// `>= $1` expiry comparison is inclusive so a commitment expiring exactly at
+// asOf stays active, matching the API layer's isActiveCommitment. It also pins
 // the full 21-column SELECT including the issue-#290 revocation columns:
 // before this fix the query selected only 17 columns while
 // queryPurchaseHistory scans 21 destinations, so every call failed at Scan.
@@ -798,7 +800,7 @@ func TestPGXMock_GetActivePurchaseHistory_Unscoped(t *testing.T) {
 	now := time.Now().Truncate(time.Second)
 	rows := pgxmock.NewRows(purchaseHistoryCols).AddRow(purchaseHistoryRow(now, "aws", "acct-1")...)
 	mock.ExpectQuery(
-		`SELECT account_id, purchase_id, .*revocation_window_closes_at, revoked_at, revoked_via, support_case_id FROM purchase_history WHERE term > 0 AND timestamp \+ make_interval\(hours => term \* 8760\) > \$1 ORDER BY timestamp DESC$`,
+		`SELECT account_id, purchase_id, .*revocation_window_closes_at, revoked_at, revoked_via, support_case_id FROM purchase_history WHERE term > 0 AND timestamp \+ make_interval\(hours => term \* 8760\) >= \$1 ORDER BY timestamp DESC$`,
 	).WithArgs(now).WillReturnRows(rows)
 
 	records, err := store.GetActivePurchaseHistory(ctx, now, nil, nil)
@@ -820,7 +822,7 @@ func TestPGXMock_GetActivePurchaseHistory_AccountScoped(t *testing.T) {
 	now := time.Now().Truncate(time.Second)
 	rows := pgxmock.NewRows(purchaseHistoryCols).AddRow(purchaseHistoryRow(now, "aws", "111122223333")...)
 	mock.ExpectQuery(
-		`FROM purchase_history WHERE term > 0 AND timestamp \+ make_interval\(hours => term \* 8760\) > \$1 AND \(cloud_account_id = ANY\(\$2\) OR \(provider = \$3 AND account_id = ANY\(\$4\)\)\) ORDER BY timestamp DESC$`,
+		`FROM purchase_history WHERE term > 0 AND timestamp \+ make_interval\(hours => term \* 8760\) >= \$1 AND \(cloud_account_id = ANY\(\$2\) OR \(provider = \$3 AND account_id = ANY\(\$4\)\)\) ORDER BY timestamp DESC$`,
 	).WithArgs(now, []string{"acct-uuid-1"}, "aws", []string{"111122223333"}).WillReturnRows(rows)
 
 	records, err := store.GetActivePurchaseHistory(ctx, now,