Repository navigation
Commit be28ac2
committed
feat(frontend/riexchange): inline column filters via shared lib
Wires per-column filter popovers to the RI Exchange reshape-recommendations
table using the helpers extracted in merged #570 (parseNumericFilter +
applyColumnFilters). Categorical columns (Source RI, Source/Target instance
types, Reason) get a checkbox-list popover; numeric columns (Source/Target
count, Utilization %, Normalized used/purchased) get a free-text expression
popover that supports `>N`, `>=N`, `<N`, `<=N`, `N..M` ranges, exact match,
and comma-separated OR.
Numeric predicates compare against the display-rounded cell value so a user
typing the displayed figure (e.g. 95.0 for utilization) matches the cell
they see. Broken expressions are skipped (inline error in the popover)
rather than collapsing the table.
Filter state lives in the RI Exchange-specific slice on state.ts; no
cross-tab coupling. No drive-by changes to the rest of the RI Exchange
page (convertible-RI table, exchange modal, automation settings, history).
Test-mocks for the riexchange + riexchange-permissions suites updated to
expose the new state getters/setters so the existing happy-path assertions
still pass.
Refs #166.1 parent dc31e54 commit be28ac2
3 files changed
Lines changed: 444 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
27 | 33 | | |
28 | 34 | | |
29 | 35 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
49 | 55 | | |
50 | 56 | | |
51 | 57 | | |
| |||
441 | 447 | | |
442 | 448 | | |
443 | 449 | | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
444 | 457 | | |
445 | 458 | | |
446 | 459 | | |
| |||
0 commit comments