Skip to content

Commit e47ba68

Browse files
committed
fix(lint): use NewRequestWithContext in httpclient tests to satisfy noctx
1 parent 8c3ab55 commit e47ba68

1 file changed

Lines changed: 11 additions & 2 deletions

File tree

‎pkg/httpclient/httpclient_test.go‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package httpclient
22

33
import (
4+
"context"
45
"net/http"
56
"net/http/httptest"
67
"strings"
@@ -35,7 +36,11 @@ func TestNew_BlocksIMDS(t *testing.T) {
3536
c := New()
3637
for _, tt := range tests {
3738
t.Run(tt.name, func(t *testing.T) {
38-
resp, err := c.Get(tt.url)
39+
req, err := http.NewRequestWithContext(context.Background(), http.MethodGet, tt.url, nil)
40+
if err != nil {
41+
t.Fatalf("build request: %v", err)
42+
}
43+
resp, err := c.Do(req)
3944
if err == nil {
4045
resp.Body.Close()
4146
t.Fatalf("request to %s must be blocked", tt.url)
@@ -53,7 +58,11 @@ func TestNew_AllowsRegularEndpoints(t *testing.T) {
5358
}))
5459
t.Cleanup(srv.Close)
5560

56-
resp, err := New().Get(srv.URL)
61+
req, err := http.NewRequestWithContext(context.Background(), http.MethodGet, srv.URL, nil)
62+
if err != nil {
63+
t.Fatalf("build request: %v", err)
64+
}
65+
resp, err := New().Do(req)
5766
if err != nil {
5867
t.Fatalf("request to non-IMDS endpoint failed: %v", err)
5968
}

0 commit comments

Comments
 (0)