diff --git a/frontend/src/__tests__/settings-accounts.test.ts b/frontend/src/__tests__/settings-accounts.test.ts index 04e4018cb..b0d1dcb97 100644 --- a/frontend/src/__tests__/settings-accounts.test.ts +++ b/frontend/src/__tests__/settings-accounts.test.ts @@ -1237,7 +1237,7 @@ describe('Account overrides modal', () => { test('Overrides button opens an account-scoped modal whose title binds to the account', async () => { (api.listAccounts as jest.Mock).mockResolvedValue([ - { id: 'acc-1', name: 'AWS Prod', provider: 'aws', external_id: '540659244915', enabled: true }, + { id: 'acc-1', name: 'AWS Prod', provider: 'aws', external_id: '123456789012', enabled: true }, ]); (api.listAccountServiceOverrides as jest.Mock).mockResolvedValue([ { id: 'o1', account_id: 'acc-1', provider: 'aws', service: 'ec2', payment: 'all-upfront' }, @@ -1245,7 +1245,7 @@ describe('Account overrides modal', () => { await loadAccountsForProvider('aws'); const btn = document.querySelector( - `button[aria-label="Service overrides for AWS Prod (540659244915)"]`, + `button[aria-label="Service overrides for AWS Prod (123456789012)"]`, ) as HTMLButtonElement; btn.click(); await new Promise(r => setTimeout(r, 0)); @@ -1253,12 +1253,12 @@ describe('Account overrides modal', () => { const modal = document.getElementById('account-overrides-modal') as HTMLElement; expect(modal.classList.contains('hidden')).toBe(false); const title = document.getElementById('account-overrides-modal-title') as HTMLElement; - expect(title.textContent).toBe('Service overrides for AWS Prod (540659244915)'); + expect(title.textContent).toBe('Service overrides for AWS Prod (123456789012)'); }); test('switching accounts swaps the modal title; only one account context is active at a time', async () => { (api.listAccounts as jest.Mock).mockResolvedValue([ - { id: 'acc-a', name: 'AWS Prod', provider: 'aws', external_id: '540659244915', enabled: true }, + { id: 'acc-a', name: 'AWS Prod', provider: 'aws', external_id: '123456789012', enabled: true }, { id: 'acc-b', name: 'CUDly host', provider: 'aws', external_id: '909626172446', enabled: true }, ]); (api.listAccountServiceOverrides as jest.Mock).mockResolvedValue([]); @@ -1268,7 +1268,7 @@ describe('Account overrides modal', () => { // Click Overrides on Account A. (document.querySelector( - `button[aria-label="Service overrides for AWS Prod (540659244915)"]`, + `button[aria-label="Service overrides for AWS Prod (123456789012)"]`, ) as HTMLButtonElement).click(); await new Promise(r => setTimeout(r, 0)); expect(titleEl.textContent).toContain('AWS Prod'); diff --git a/internal/email/template_renderers_test.go b/internal/email/template_renderers_test.go index fc42a4bb0..44e377d9c 100644 --- a/internal/email/template_renderers_test.go +++ b/internal/email/template_renderers_test.go @@ -269,7 +269,7 @@ func TestRenderPurchaseApprovalRequestEmail_NewContextFields_Issue287(t *testing Recommendations: []RecommendationSummary{{ Service: "ec2", ResourceType: "m5.large", Region: "us-east-1", Count: 8, Term: 3, Payment: "all-upfront", UpfrontCost: 1234.56, - MonthlySavings: 58.0, AccountLabel: "AWS 540659244915", + MonthlySavings: 58.0, AccountLabel: "AWS 123456789012", }}, } @@ -280,7 +280,7 @@ func TestRenderPurchaseApprovalRequestEmail_NewContextFields_Issue287(t *testing assert.Contains(t, body, "Term: 3yr") assert.Contains(t, body, "Payment: all-upfront") assert.Contains(t, body, "Upfront: $1234.56") - assert.Contains(t, body, "Account: AWS 540659244915") + assert.Contains(t, body, "Account: AWS 123456789012") // Requested-by header. assert.Contains(t, body, "Cristi M") @@ -318,7 +318,7 @@ func TestRenderPurchaseApprovalRequestEmailHTML_Issue287(t *testing.T) { Recommendations: []RecommendationSummary{{ Service: "ec2", ResourceType: "m5.large", Region: "us-east-1", Count: 8, Term: 3, Payment: "all-upfront", UpfrontCost: 1234.56, - MonthlySavings: 58.0, AccountLabel: "AWS 540659244915", + MonthlySavings: 58.0, AccountLabel: "AWS 123456789012", }}, } diff --git a/known_issues/23_ux_review_2026_04_22.md b/known_issues/23_ux_review_2026_04_22.md index 1aed90a8f..5bdbc9337 100644 --- a/known_issues/23_ux_review_2026_04_22.md +++ b/known_issues/23_ux_review_2026_04_22.md @@ -507,7 +507,7 @@ #### MEDIUM: Per-provider Accounts sections render as inline text rows — need a table -**Evidence:** `AWS personal (540659244915) Edit Test Credentials Overrides Delete` is a single text-flow line. Hard to scan. +**Evidence:** `AWS personal (123456789012) Edit Test Credentials Overrides Delete` is a single text-flow line. Hard to scan. **Recommended fix:** Convert to a table: `Name | ID | Status | Actions`.