From 4662846cacb1fc418be48522c5156935f57bae42 Mon Sep 17 00:00:00 2001
From: Cristian Magherusan-Stanciu <cristi.magherusan@gmail.com>
Date: Thu, 28 May 2026 20:51:20 +0200
Subject: [PATCH] test(plans): assert 3-SP plan card lists all plan types
 (closes #248)

Add regression test for issue #248: a purchase plan covering Compute SP,
EC2 Instance SP, and SageMaker SP must render all three labels comma-joined
in the Service detail row of the plan card, not just the first entry.
---
 frontend/src/__tests__/plans.test.ts | 60 ++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/frontend/src/__tests__/plans.test.ts b/frontend/src/__tests__/plans.test.ts
index 188017121..4840fbaf8 100644
--- a/frontend/src/__tests__/plans.test.ts
+++ b/frontend/src/__tests__/plans.test.ts
@@ -256,6 +256,66 @@ describe('Plans Module', () => {
       expect(list?.innerHTML).not.toContain('Multiple');
     });
 
+    test('three-SP plan summary lists all three plan types comma-joined (issue #248)', async () => {
+      // Regression guard for issue #248: a plan targeting Compute SP,
+      // EC2 Instance SP, and SageMaker SP must show all three labels in
+      // the Service detail row of the plan card, comma-joined, rather
+      // than collapsing to just the first entry.
+      (api.getPlans as jest.Mock).mockResolvedValue({
+        plans: [
+          {
+            id: 'plan-three-sp',
+            name: 'Three SP plan',
+            enabled: true,
+            auto_purchase: true,
+            services: {
+              'aws:savings-plans-compute': {
+                provider: 'aws',
+                service: 'savings-plans-compute',
+                enabled: true,
+                term: 3,
+                payment: 'no-upfront',
+                coverage: 80,
+              },
+              'aws:savings-plans-ec2instance': {
+                provider: 'aws',
+                service: 'savings-plans-ec2instance',
+                enabled: true,
+                term: 3,
+                payment: 'no-upfront',
+                coverage: 80,
+              },
+              'aws:savings-plans-sagemaker': {
+                provider: 'aws',
+                service: 'savings-plans-sagemaker',
+                enabled: true,
+                term: 3,
+                payment: 'no-upfront',
+                coverage: 80,
+              },
+            },
+            ramp_schedule: {
+              type: 'immediate',
+              percent_per_step: 100,
+              step_interval_days: 0,
+              current_step: 0,
+              total_steps: 1,
+            },
+          },
+        ],
+      });
+      (api.getPlannedPurchases as jest.Mock).mockResolvedValue({ purchases: [] });
+
+      await loadPlans();
+
+      const list = document.getElementById('plans-list');
+      expect(list?.innerHTML).toContain('Compute SP');
+      expect(list?.innerHTML).toContain('EC2 Instance SP');
+      expect(list?.innerHTML).toContain('SageMaker SP');
+      // All three labels must appear together in the same Service detail value.
+      expect(list?.innerHTML).toMatch(/Compute SP.*EC2 Instance SP.*SageMaker SP/);
+    });
+
     test('single-service plan still renders one label (no regression)', async () => {
       (api.getPlans as jest.Mock).mockResolvedValue({
         plans: [