Unused count in hm2 bspi

[BsAtHome]

@andypugh You added a variable in the hostmot2 buffered SPI drivers called count using the hal_u32_t * type. This field is never addressed or used in the bspi driver afaics. It may have been the idea to add a pin, but the SPI interface is a rather "internal use only" construct where other modules use it as a transport layer, just like the uart/pktuart. It may therefore be a "leftover" while developing the driver.

Commenting it out and recompiling does not result in any messages, so it does not seem to be addressed anywhere. Can't it be simply removed?

The source is at: https://github.com/LinuxCNC/linuxcnc/blame/e90c66dac743dc0bf9f827f70fab5cdd8898c662/src/hal/drivers/mesa-hostmot2/hostmot2.h#L1338
Added in commit: d82b0eb

[andypugh]

I think it probably could be removed.
There is a small chance that somewhere out there a HAL driver is using the BSPI interface and creating a pin that uses it, but it seems unlikely.
Naturally I have forgotten why I created it after this length of time.

[BsAtHome]

It is not an in-tree driver that is using it. Otherwise it would have triggered a compile problem.

Out-of-tree may be a remote issue. However, the proper separation for drivers layered on top of BSPI is to allocate their own hal memory (and pins). The underlying structures should be considered opaque for higher level drivers.

Memory is volatile. Be happy about that. You wouldn't want to remember everything of all you ever did (or didn't do), think or experience ;-)

Will remove.