From a7a60ed2fa749e3eeed36a867894c3c63c494db1 Mon Sep 17 00:00:00 2001 From: Xavier Claude Date: Thu, 26 Mar 2026 10:24:32 +0200 Subject: [PATCH 1/2] Allow to disable the automatic rdb snapshot in valkey By default, Valkey dumps regularly a snapshot, on testing/demo environnment, we may want to avoid the extra fs pressure --- docker-compose.yml | 10 ++++++++-- template.env | 2 ++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/docker-compose.yml b/docker-compose.yml index 7749b2d..7dbabf0 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -23,16 +23,22 @@ services: restart: always command: | sh -c ' + if [ "$${ENABLE_REDIS_SNAPSHOT}" = "false" ] ; then + redis_snapshot="--save \"\"" + else + redis_snapshot="" + fi if [ "$${ENABLE_REDIS_EMPTY_PASSWORD:-false}" = "true" ]; then - exec valkey-server + exec valkey-server $${redis_snapshot} else - exec valkey-server --requirepass "$${REDIS_PASSWORD:-redispassword}" + exec valkey-server --requirepass "$${REDIS_PASSWORD:-redispassword}" $${redis_snapshot} fi ' environment: - "ENABLE_REDIS_EMPTY_PASSWORD=${ENABLE_REDIS_EMPTY_PASSWORD:-false}" - "REDIS_PASSWORD=${REDIS_PASSWORD:-redispassword}" - "TZ=${TZ:-UTC}" + - "ENABLE_REDIS_SNAPSHOT=${ENABLE_REDIS_SNAPSHOT:-true}" healthcheck: test: | sh -c ' diff --git a/template.env b/template.env index 0602438..b9da7ba 100644 --- a/template.env +++ b/template.env @@ -146,6 +146,8 @@ SYNCSERVERS_1_PULL_RULES= # REDIS_PASSWORD= # Enable passwordless Redis connection (defaults to false for security) # ENABLE_REDIS_EMPTY_PASSWORD=false +# Enable automatic snapshot dump to disk (defaults to true) +# ENABLE_REDIS_SNAPSHOT=true # These variables allows overriding some MISP email values. # They all default to ADMIN_EMAIL. From 93fb8044ddfba3420c6d2eddef2e6cee1fbeff38 Mon Sep 17 00:00:00 2001 From: Xavier Claude Date: Mon, 30 Mar 2026 14:35:37 +0200 Subject: [PATCH 2/2] Rename ENABLE to DISABLE for REDIS_SNAPSHOT --- docker-compose.yml | 4 ++-- template.env | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docker-compose.yml b/docker-compose.yml index 7dbabf0..c6eb627 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -23,7 +23,7 @@ services: restart: always command: | sh -c ' - if [ "$${ENABLE_REDIS_SNAPSHOT}" = "false" ] ; then + if [ "$${DISABLE_REDIS_SNAPSHOT}" = "true" ] ; then redis_snapshot="--save \"\"" else redis_snapshot="" @@ -38,7 +38,7 @@ services: - "ENABLE_REDIS_EMPTY_PASSWORD=${ENABLE_REDIS_EMPTY_PASSWORD:-false}" - "REDIS_PASSWORD=${REDIS_PASSWORD:-redispassword}" - "TZ=${TZ:-UTC}" - - "ENABLE_REDIS_SNAPSHOT=${ENABLE_REDIS_SNAPSHOT:-true}" + - "DISABLE_REDIS_SNAPSHOT=${DISABLE_REDIS_SNAPSHOT:-false}" healthcheck: test: | sh -c ' diff --git a/template.env b/template.env index b9da7ba..00a558e 100644 --- a/template.env +++ b/template.env @@ -146,8 +146,8 @@ SYNCSERVERS_1_PULL_RULES= # REDIS_PASSWORD= # Enable passwordless Redis connection (defaults to false for security) # ENABLE_REDIS_EMPTY_PASSWORD=false -# Enable automatic snapshot dump to disk (defaults to true) -# ENABLE_REDIS_SNAPSHOT=true +# Disable automatic snapshot dump to disk (defaults to false) +# DISABLE_REDIS_SNAPSHOT=false # These variables allows overriding some MISP email values. # They all default to ADMIN_EMAIL.