mb/google/puff: program RTL8168 MAC into ERI#31
Draft
jackadam1981 wants to merge 1 commit into
Draft
Conversation
Owner
|
this looks good, I think I'll break this up into 2 commits, and apply it to other chromeboxes with RT81xx. Fizz uses Rev 0x15 as as well, I need to check the others. |
Owner
|
here's what I upstreamed, thoughts? https://review.coreboot.org/c/coreboot/+/93049 |
Owner
|
the above patch series has been cherry-picked back into 2603 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the PXE MAC address on Google Puff-derived KAISA systems (Acer Chromebox CXI4) with the onboard Realtek RTL8111/8168 controller.
On the tested KAISA unit, Linux still reported the correct VPD-backed MAC address, but the firmware PXE path showed an all-zero MAC address (
00:00:00:00:00:00). The board already selectsRT8168_GET_MAC_FROM_VPD, so coreboot reads the right address, but the RTL8168 hardware also needs the address programmed into the ERI registers for this controller revision before the PXE stack uses it.Changes
RT8168_PUT_MAC_TO_ERIfor the Puff baseboard so KAISA programs the VPD MAC into the controller ERI registers.0x15/ decimal21like revision9in the RTL8168 ERI MAC programming path.Hardware details
The tested onboard NIC is:
rev 15is hexadecimal, so this is PCI revision ID0x15/ decimal21, matching the newcase 21path.Validation
Built a 2603 release ROM for KAISA with PXE + iPXE enabled, using the MrChromebox 2603 coreboot/EDK2 sources plus this two-line change.
Test ROM:
Flashed on a real Acer Chromebox CXI4 / KAISA using the MrChromebox firmware utility. The utility preserved VPD, RW_MRC_CACHE, and SMMSTORE during the custom flash. After reboot, the PXE screen showed the MAC address instead of all zeros.