Repository navigation
Vouch request: [your GitHub username] #4227
agammann
started this conversation in
Vouch Request
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
What do you want to work on?
OpenShell TypeScript SDK bug fix in PR #4226. The SDK mishandles gateway URLs starting with uppercase HTTPS://, rejecting bearer tokens and omitting mTLS credentials. The fix and tests are already done.
Why this change?
Because HTTPS:// is a valid URL scheme, but OpenShell’s TypeScript SDK treats it differently from https://. That makes it reject a bearer token or omit mTLS credentials for a secure gateway URL, breaking a configuration that should work. We reproduced that behavior and tested the fix in PR #4226. A URL like HTTPS://gateway.example is valid and means the same thing as https://gateway.example. The SDK checked the raw text with a lowercase-only startsWith('https://'), so it misclassified the uppercase version as insecure. That caused it to reject a bearer token and leave out mTLS credentials. The change checks the URL’s parsed protocol instead. That gives the SDK the same answer the URL parser and transport use, regardless of scheme casing.
Checklist
All reactions